lint: variable names fix

Signed-off-by: Aryan Goyal <[email protected]>
open-telemetry · Jan 8, 2025 · 6bc7e16 · 6bc7e16
1 parent 50def7e
commit 6bc7e16
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/extension/jaegerremotesampling/internal/source/filesource/filesource.go b/extension/jaegerremotesampling/internal/source/filesource/filesource.go
@@ -71,7 +71,7 @@ func NewFileSource(options Options, logger *zap.Logger) (source.Source, error) {
 		h.logger.Warn("Default operations level strategies will not be included for Ratelimiting service strategies." +
 			"This behavior will be changed in future releases. " +
 			"Cf. https://github.com/jaegertracing/jaeger/issues/5270")
-		h.parseStrategies_deprecated(strategies)
+		h.parseStrategiesDeprecated(strategies)
 	} else {
 		h.parseStrategies(strategies)
 	}
@@ -209,7 +209,7 @@ func loadStrategies(loadFn strategyLoader) (*strategies, error) {
 	return strategies, nil
 }
 
-func (h *samplingProvider) parseStrategies_deprecated(strategies *strategies) {
+func (h *samplingProvider) parseStrategiesDeprecated(strategies *strategies) {
 	newStore := defaultStrategies()
 	if strategies.DefaultStrategy != nil {
 		newStore.defaultStrategy = h.parseServiceStrategies(strategies.DefaultStrategy)

diff --git a/extension/jaegerremotesampling/internal/source/filesource/filesource_test.go b/extension/jaegerremotesampling/internal/source/filesource/filesource_test.go
@@ -515,19 +515,19 @@ func TestServiceNoPerOperationStrategies(t *testing.T) {
 		t.Run(service, func(t *testing.T) {
 			strategy, err := provider.GetSamplingStrategy(context.Background(), service)
 			require.NoError(t, err)
-			strategyJson, err := json.MarshalIndent(strategy, "", "  ")
+			strategyJSON, err := json.MarshalIndent(strategy, "", "  ")
 			require.NoError(t, err)
 
 			testName := strings.ReplaceAll(t.Name(), "/", "_")
 			snapshotFile := filepath.Join(snapshotLocation, testName+".json")
 			expectedServiceResponse, err := os.ReadFile(snapshotFile)
 			require.NoError(t, err)
 
-			assert.JSONEq(t, string(expectedServiceResponse), string(strategyJson),
+			assert.JSONEq(t, string(expectedServiceResponse), string(strategyJSON),
 				"comparing against stored snapshot. Use REGENERATE_SNAPSHOTS=true to rebuild snapshots.")
 
 			if regenerateSnapshots {
-				err = os.WriteFile(snapshotFile, strategyJson, 0o600)
+				err = os.WriteFile(snapshotFile, strategyJSON, 0o600)
 				require.NoError(t, err)
 			}
 		})
@@ -548,19 +548,19 @@ func TestServiceNoPerOperationStrategiesDeprecatedBehavior(t *testing.T) {
 		t.Run(service, func(t *testing.T) {
 			strategy, err := provider.GetSamplingStrategy(context.Background(), service)
 			require.NoError(t, err)
-			strategyJson, err := json.MarshalIndent(strategy, "", "  ")
+			strategyJSON, err := json.MarshalIndent(strategy, "", "  ")
 			require.NoError(t, err)
 
 			testName := strings.ReplaceAll(t.Name(), "/", "_")
 			snapshotFile := filepath.Join(snapshotLocation, testName+".json")
 			expectedServiceResponse, err := os.ReadFile(snapshotFile)
 			require.NoError(t, err)
 
-			assert.JSONEq(t, string(expectedServiceResponse), string(strategyJson),
+			assert.JSONEq(t, string(expectedServiceResponse), string(strategyJSON),
 				"comparing against stored snapshot. Use REGENERATE_SNAPSHOTS=true to rebuild snapshots.")
 
 			if regenerateSnapshots {
-				err = os.WriteFile(snapshotFile, strategyJson, 0o600)
+				err = os.WriteFile(snapshotFile, strategyJSON, 0o600)
 				require.NoError(t, err)
 			}
 		})