Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/clamp the params and s #148

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix/clamp the params and s #148

merged 2 commits into from
Jan 22, 2025
+67 −22

Conversation

ishiko732
Copy link
Collaborator

For testing, please use:

# production
pnpm install github:open-spaced-repetition/ts-fsrs#Fix/clamp

# development
export NODE_ENV=development
pnpm install github:open-spaced-repetition/ts-fsrs#Fix/clamp

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ad71683) to head (2a519e0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          722       734   +12     
  Branches        85        85           
=========================================
+ Hits           722       734   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

L-M-Sherlock
L-M-Sherlock approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishiko732 ishiko732 merged commit 4998232 into main Jan 22, 2025
5 checks passed
@ishiko732 ishiko732 deleted the Fix/clamp branch January 22, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-M-Sherlock L-M-Sherlock L-M-Sherlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishiko732 @L-M-Sherlock