improve code coverage

open-southeners · Jan 5, 2024 · 91f37d5 · 91f37d5
1 parent 556cf6c
commit 91f37d5
Show file tree

Hide file tree

Showing 3 changed files with 100 additions and 0 deletions.
diff --git a/src/ServiceProvider.php b/src/ServiceProvider.php
@@ -33,7 +33,9 @@ protected function registerAboutCommandInfo(): void
     {
         // The about command is only available in Laravel 9 and up so we need to check if it's available to us
         if (! class_exists(AboutCommand::class)) {
+            // @codeCoverageIgnoreStart
             return;
+            // @codeCoverageIgnoreEnd
         }
 
         AboutCommand::add('Integrations', [

diff --git a/tests/RenderTest.php b/tests/RenderTest.php
@@ -52,6 +52,65 @@ public function testGenerateRender()
         $this->assertEquals('ai9PAfUoDV1mfbjQsGzDtjCJMTNk2N7FDFb8fTwwgnYqFdfgvcWryniPQnkUTke4', $response->getRenderId());
     }
 
+    public function testGenerateRenderConvertToAcceptsString()
+    {
+        $mockClient = new MockClient([
+            Render\GenerateDocumentUsingTemplate::class => MockResponse::make([
+                'success' => true,
+                'data' => [
+                    'renderId' => 'ai9PAfUoDV1mfbjQsGzDtjCJMTNk2N7FDFb8fTwwgnYqFdfgvcWryniPQnkUTke4',
+                ],
+            ]),
+        ]);
+
+        $this->carbone->withMockClient($mockClient);
+
+        $data = new \OpenSoutheners\CarboneSdk\Data\Render(
+            data: [
+                'foo' => 'bar',
+                'hello' => 'world',
+            ],
+            convertTo: 'pdf'
+        );
+
+        $response = $this->carbone->render()->generate(
+            'qjaRALD5xIdNdwaXrbLZbuWuZfrGPPT1kdoh82mULevAv904gWNtba9kkAwU5Uef',
+            $data
+        );
+
+        $mockClient->assertSent(Render\GenerateDocumentUsingTemplate::class);
+
+        $this->assertTrue($response->ok());
+        $this->assertEquals('ai9PAfUoDV1mfbjQsGzDtjCJMTNk2N7FDFb8fTwwgnYqFdfgvcWryniPQnkUTke4', $response->getRenderId());
+    }
+
+    public function testGenerateRenderGetRenderIdAsNullWhenFailure()
+    {
+        $mockClient = new MockClient([
+            Render\GenerateDocumentUsingTemplate::class => MockResponse::make([
+                'success' => false,
+                'error' => 'Invalid templateId',
+            ], 400),
+        ]);
+
+        $this->carbone->withMockClient($mockClient);
+
+        $data = new \OpenSoutheners\CarboneSdk\Data\Render(
+            data: [
+                'foo' => 'bar',
+                'hello' => 'world',
+            ],
+            convertTo: RenderFormat::Pdf
+        );
+
+        $response = $this->carbone->render()->generate('dunno', $data);
+
+        $mockClient->assertSent(Render\GenerateDocumentUsingTemplate::class);
+
+        $this->assertTrue($response->failed());
+        $this->assertNull($response->getRenderId());
+    }
+
     public function testRetrieveRender()
     {
         $content = file_get_contents(__DIR__.'/fixtures/my_template.xlsx');

diff --git a/tests/TemplateTest.php b/tests/TemplateTest.php
@@ -42,6 +42,27 @@ public function testUploadTemplate()
         $this->assertEquals('qjaRALD5xIdNdwaXrbLZbuWuZfrGPPT1kdoh82mULevAv904gWNtba9kkAwU5Uef', $response->getTemplateId());
     }
 
+    public function testUploadTemplateThatFails()
+    {
+        $mockClient = new MockClient([
+            Template\UploadTemplate::class => MockResponse::make([
+                'success' => false,
+                'error' => 'Cannot store template',
+            ], 400),
+        ]);
+
+        $this->carbone->withMockClient($mockClient);
+
+        $templateContent = '';
+
+        $response = $this->carbone->template()->upload($templateContent);
+
+        $mockClient->assertSent(Template\UploadTemplate::class);
+
+        $this->assertTrue($response->failed());
+        $this->assertNull($response->getTemplateId());
+    }
+
     public function testBase64UploadTemplate()
     {
         $mockClient = new MockClient([
@@ -83,6 +104,24 @@ public function testDeleteTemplate()
         $this->assertEquals(true, $response->json('success'));
     }
 
+    public function testCheckTemplateExist()
+    {
+        $mockClient = new MockClient([
+            Template\CheckTemplateExists::class => MockResponse::make(),
+        ]);
+
+        $this->carbone->withMockClient($mockClient);
+
+        $templateId = 'qjaRALD5xIdNdwaXrbLZbuWuZfrGPPT1kdoh82mULevAv904gWNtba9kkAwU5Uef';
+
+        $response = $this->carbone->template()->exists($templateId);
+
+        $mockClient->assertSent(Template\CheckTemplateExists::class);
+
+        $this->assertTrue($response->ok());
+        $this->assertEmpty($response->json());
+    }
+
     public function testDownloadTemplate()
     {
         $content = file_get_contents(__DIR__.'/fixtures/my_template.xlsx');