-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary Upgrade (named Alpaca) to Prepare for Larger Upgrades #13
Open
kk-chung
wants to merge
35
commits into
open-osp:main
Choose a base branch
from
MagentaHealth:develop/alpaca
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed ebs-client 0.0.6, implemented the customized ebs-client classes.
Avoided looking for XOP references in the response by setting the properties to "0".
…rror. Fixed the header parsing error to enable the list being displayed on both Sent and Download pages. Fixed the signature invalid error to enable downloading the files.
….getBean when running MCEDT tests.
- Removed commented-out codes - Removed useless white spaces - Reformatted the class files - Added comments to EDTBaseTest.java to make the code understandable - Changed clientKeyStore.properties to the original version, changed the file path - Removed "/applicationContextBORN.xml" from the EDTBaseTest class since the tests never use this context
- Updated the jdoc in AttachmentCachingInterceptor.java, added jdocs to its methods - Updated the jdoc in AttachmentCleanupInterceptor.java, added jdocs to its methods - Updated the jdoc in AttachmentResolverSpi.java, added jdocs to its methods - Added the jdocs in ClientPasswordCallback.java and its methods - Added the jdocs in DownloadInInterceptor.java and its methods - Updated the jdoc in EdtClientBuilder.java, added jdocs to its methods - Added the jdocs in EdtClientBuilderConfig.java and its methods - Added the jdoc in TransformAttachmentCiphertext.java - Added the jdocs to the methods in WSS4JInNonValidatingActionInterceptor.java
…ensure they all pass.
Upgraded Struts version from 1.3.8 to 1.3.11. Fix a NullPointerException issue that occurred when upload client image due to the version upgrade.
…les, added necessary comments. - Removed commented-out codes - Removed useless white spaces - Reformatted the class files - Added comments to EDTBaseTest.java to make the code understandable
- Added information about XOP references issue - Added more information about the test cases
- oscarehr/integration/mcedt/DelegateFactory.java - oscarehr/integration/mchcv/OnlineHCValidator.java
fix: re-add devcontainer openosp_files
- Added jspc dependency to compile the jsp files - Fixed jsp compilation errors
- The tmp directory will contains the documents generated by the tests to avoid the tests failed due to missing file directory.
- Added `uid` column back, and inserted the uid data
… MagentaHealth-develop/alpaca
Push changes from develop/alpaca to upstream
@warrendennis sorry - I can't seem to "assign" this PR to you |
lacarmen
referenced
this pull request
in MagentaHealth/Open-O
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In broad strokes:
Other changes were as discussed between maintainer (DW) and supervisor (MY). The submitter of this PR (KC) has very little involvement except for being able to warrant that this code was tested by the internal team, and has been running in production for 2 weeks with no issues identified.