Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #19201: Fix connection password masking #19749

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix #19201: Fix connection password masking #19749

merged 2 commits into from
Feb 12, 2025

Conversation

ulixius9
Copy link
Member

@ulixius9 ulixius9 commented Feb 11, 2025 •
edited
Loading

Describe your changes:

Fix #19201: Fix connection password masking

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ulixius9 ulixius9 requested review from a team as code owners February 11, 2025 11:24
@ulixius9 ulixius9 added the To release Will cherry-pick this PR into the release branch label Feb 11, 2025
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.63% (41371/64009) 41% (16708/40755) 44.22% (5040/11398)

@ulixius9 ulixius9 requested a review from a team as a code owner February 12, 2025 05:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

SumanMaharana
SumanMaharana approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@SumanMaharana SumanMaharana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulixius9 ulixius9 merged commit e873ba0 into main Feb 12, 2025
23 of 27 checks passed
@ulixius9 ulixius9 deleted the issue-19201 branch February 12, 2025 10:46
@github-actions GitHub Actions
Copy link
Contributor

Failed to cherry-pick changes to the 1.6.4 branch.
Please cherry-pick the changes manually.
You can find more details here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonika-shah sonika-shah sonika-shah approved these changes

@SumanMaharana SumanMaharana SumanMaharana approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nifi connection details shows password unmasked
3 participants
@ulixius9 @sonika-shah @SumanMaharana