Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-19651: handle starburst JWToken expiration #19689

Merged
merged 2 commits into from
Feb 7, 2025
Merged

ISSUE-19651: handle starburst JWToken expiration #19689

merged 2 commits into from
Feb 7, 2025

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Feb 6, 2025 •
edited
Loading

Describe your changes:

Fixes #19651

  • handle starburst JWToken expiration -- if is_disconnect returns True, connection will be invalidated from the pool and a new one created.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@TeddyCr TeddyCr requested a review from a team as a code owner February 6, 2025 09:41
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 6, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
37.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TeddyCr TeddyCr merged commit e90bf9d into open-metadata:main Feb 7, 2025
12 of 17 checks passed
TeddyCr added a commit that referenced this pull request Feb 12, 2025
@TeddyCr
ISSUE-19651: handle starburst JWToken expiration (#19689)
7380151 
* fix: handle starburst JWToken expiration

* style: ran python linting

(cherry picked from commit e90bf9d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceS2 IceS2 IceS2 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle Trino JWToken expiration
2 participants
@TeddyCr @IceS2