Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#19363: remove isNull and not null condition from description in advance search #19661

Merged
merged 1 commit into from
Feb 5, 2025
Merged

#19363: remove isNull and not null condition from description in advance search #19661

merged 1 commit into from
Feb 5, 2025

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 4, 2025 •
edited
Loading

Describe your changes:

Issue #19363

  • I worked on removing isNull and is not null condition from description and column description field, since here we have only 2 criteria of COMPLETE and INCOMPLETE, and the above 2 condition will not work in this case.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Feb 4, 2025
@Ashish8689 Ashish8689 self-assigned this Feb 4, 2025
@Ashish8689 Ashish8689 requested a review from a team as a code owner February 4, 2025 09:20
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 4, 2025
@Ashish8689 Ashish8689 changed the title MINOR: remove isNull and not null condition from description in advance search #19363: remove isNull and not null condition from description in advance search Feb 4, 2025
@Ashish8689 Ashish8689 added the To release Will cherry-pick this PR into the release branch label Feb 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.52% (41157/63791) 40.88% (16572/40539) 44.09% (5006/11355)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit 2510a37 into main Feb 5, 2025
28 of 37 checks passed
@Ashish8689 Ashish8689 deleted the remove-unwanted-description-condition branch February 5, 2025 05:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Changes have been cherry-picked to the 1.6.4 branch.

github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
@Ashish8689
remove isNull and not null conditon from descripiton in advance search (
e58ec94 
#19661)

(cherry picked from commit 2510a37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @chirag-madlani