MINOR: Use namespaced variables #19648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
Jest test CoverageUI tests summary
|
pmbrull
previously approved these changes
Feb 3, 2025
...ata-service/src/main/java/org/openmetadata/service/governance/workflows/WorkflowHandler.java
Outdated
Show resolved
Hide resolved
sushi30
reviewed
Feb 4, 2025
...ata-service/src/main/java/org/openmetadata/service/governance/workflows/WorkflowHandler.java
Outdated
Show resolved
Hide resolved
sushi30
reviewed
Feb 4, 2025
...ata-service/src/main/java/org/openmetadata/service/governance/workflows/WorkflowHandler.java
Outdated
Show resolved
Hide resolved
sushi30
requested changes
Feb 4, 2025
There was a problem hiding this comment.
The implementation works and is good. Left some comments/suggestions regarding validations. The only blocker is regarding the use of null as namespace. Other comments are suggestions/discussions for streamlining the API and offloading as of the validation as possible to the workflow definition:
- validate inputs are valid in terms of given available nodes and compatibility of output to input.
- validate edge conditions are valid given the variable type they're referring to.
...rvice/governance/workflows/elements/nodes/automatedTask/impl/SetEntityCertificationImpl.java
Show resolved
Hide resolved
...rvice/src/main/java/org/openmetadata/service/governance/workflows/WorkflowEventConsumer.java
Show resolved
Hide resolved
...json/schema/governance/workflows/elements/nodes/automatedTask/checkEntityAttributesTask.json
Show resolved
Hide resolved
...son/schema/governance/workflows/elements/nodes/automatedTask/setEntityCertificationTask.json
Show resolved
Hide resolved
...data-service/src/main/resources/json/data/governance/workflows/GlossaryApprovalWorkflow.json
Show resolved
Hide resolved
...ata-service/src/main/java/org/openmetadata/service/governance/workflows/WorkflowHandler.java
Outdated
Show resolved
Hide resolved
pmbrull
approved these changes
Feb 10, 2025
|
|
karanh37
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
In order to be able to have different tasks in a single workflow running in parallel, we need to have namespaced variables.
Until now we were using hardcoded values so one task would overwrite or read the result from another one.
This implementation basically does the following:
<namespace>_<variable_name>globalnamespaceThis PR also removes some unused code that was added before:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>