Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): Improve the e2e for advanced search filters on Explore page #19584

Merged
merged 12 commits into from
Feb 6, 2025
Merged

test(e2e): Improve the e2e for advanced search filters on Explore page #19584

merged 12 commits into from
Feb 6, 2025

Conversation

rushikesh1799
Copy link
Contributor

@rushikesh1799 rushikesh1799 commented Jan 29, 2025 •
edited by Ashish8689
Loading

Describe your changes:

  • I worked on adding the newly added advanced search filters/fields to the explore page e2e tests.

Pending Fields :

  • Charts
  • Column Description
  • Container Column
  • Custom Properties
  • Data Model
  • Deleted
  • Description
  • Entity Type
  • Request Schema Field
  • Response Schema Field
  • Table Type

Fixes #16082

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@rushikesh1799 rushikesh1799 requested a review from a team as a code owner January 29, 2025 08:10
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@aniketkatkar97 aniketkatkar97 added the safe to test Add this label to run secure Github workflows on PRs label Jan 31, 2025
@Ashish8689 Ashish8689 added the To release Will cherry-pick this PR into the release branch label Feb 6, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit 7595288 into open-metadata:main Feb 6, 2025
19 of 30 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Changes have been cherry-picked to the 1.6.4 branch.

github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
@rushikesh1799
test(e2e): Improve the e2e for advanced search filters on Explore page (
4593163 
#19584)

* fix: add more fields for advance search filters

* added more children values data in respective classes for tests

* added some more fields for advance search filters

* added project and status fields for search filter

* added Glossary field and some code refactoring

* updated EntityDataClass with new entities required for AdvanceSearch spec

* removed some hard coded field values

* updated advancedSearch with additional fields

* removed failing tests of additional fields

* remove failing fields for now to make the test green

* remove the config changes from the PR

---------

Co-authored-by: Ashish Gupta <[email protected]>
(cherry picked from commit 7595288)
@Ashish8689
Copy link
Contributor

PR for some pending fields #19695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketkatkar97 aniketkatkar97 aniketkatkar97 approved these changes

Assignees

@rushikesh1799 rushikesh1799

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the e2e for advanced search filters
3 participants
@rushikesh1799 @Ashish8689 @aniketkatkar97