Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Recreate Out of executors #19501

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Move Recreate Out of executors #19501

merged 4 commits into from
Jan 24, 2025
+82 −70

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Jan 23, 2025 •
edited
Loading

Describe your changes:

  1. Moving Recreate out of Job Exector to process before sending data
  2. Fixed list iterator issue on referred column being null
  3. Added option to supply entities on reindex from operations

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Jan 23, 2025
@mohityadav766 mohityadav766 requested a review from a team as a code owner January 23, 2025 16:00
@mohityadav766 mohityadav766 added the To release Will cherry-pick this PR into the release branch label Jan 23, 2025
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Jan 23, 2025
harshach
harshach previously approved these changes Jan 23, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mohityadav766 mohityadav766 merged commit 907eb7c into main Jan 24, 2025
15 of 17 checks passed
@mohityadav766 mohityadav766 deleted the recreate-fix branch January 24, 2025 05:08
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
@mohityadav766
Move Recreate Out of executors (#19501)
8077c50 
* Move Recreate Out of executors

* Add Entities option in Operations

* Fix Reindexing for null list for referred columns

(cherry picked from commit 907eb7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach left review comments

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohityadav766 @harshach