Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): infinite loading for refresh attempted on app visit #19491

Merged
merged 5 commits into from
Jan 24, 2025
Merged

fix(ui): infinite loading for refresh attempted on app visit #19491

merged 5 commits into from
Jan 24, 2025
+41 −12

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes: Loading issue when user visit application with expired token and valid refresh token

  • If we try to access our app which has an expired token but a valid refreshToken, we try to get new token using the refreshToken.
  • During this process we couldn't recover app from forever loading state
  • To avoid that I have adjust code to recall all the failed api calls so that app will work normally..

Issue

I have to refresh the page to app works

Screen.Recording.2025-01-23.at.2.26.02.PM.mov

Fix

No need to do anything to make app work

Screen.Recording.2025-01-23.at.2.26.45.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani chirag-madlani added the To release Will cherry-pick this PR into the release branch label Jan 23, 2025
@chirag-madlani chirag-madlani requested a review from a team as a code owner January 23, 2025 08:58
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Jan 23, 2025
aniketkatkar97
aniketkatkar97 previously approved these changes Jan 23, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.63% (40893/63277) 40.68% (16356/40208) 44.09% (4970/11272)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit 1e7377c into main Jan 24, 2025
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the fix-infinite-loading branch January 24, 2025 05:46
@github-actions GitHub Actions
Copy link
Contributor

Failed to cherry-pick changes to the 1.6.3 branch.
Please cherry-pick the changes manually.
You can find more details here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@aniketkatkar97 aniketkatkar97 aniketkatkar97 left review comments

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirag-madlani @aniketkatkar97 @ShaileshParmar11