Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Failing e2e test for Customize page landing #19490

Conversation

shrushti2000
Copy link
Contributor

This PR addresses intermittent test failures for Customize Page Landing ,caused by dynamic elements not being fully loaded before assertions are run. The issue was observed in scenarios where network requests or dynamic rendering delayed the appearance of widgets on the page after redirection to homepage .

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@shrushti2000 shrushti2000 changed the title Fix: failing e2e test for Customize page landing Fix: Failing e2e test for Customize page landing Jan 23, 2025
@Ashish8689 Ashish8689 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 23, 2025
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.63% (40892/63274) 40.67% (16344/40189) 44.09% (4970/11272)

Copy link

@chirag-madlani chirag-madlani merged commit b3d0007 into open-metadata:main Jan 24, 2025
34 of 51 checks passed
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants