Unpinned google-cloud-secret-manager version in ingestion dependencies #19469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
TeddyCr
added
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Updated ingestion dependencies to not require specific version (2.19.0) of
google-cloud-secret-manager.While this version was very fresh when introduced to ingestion module, it's not compatible with protobuf 5.x, which was fixed in later releases. This causes installation of
openmetadata-ingestiontogether with latest versions of packages likeapache-airflowordbt-corevery slow or even impossible (pip fails to resolve dependencies). Allowing higher versions ofgoogle-cloud-secret-managerresolves this issue, and at the same time it doesn't impact how ingestion module works.Type of change:
Checklist: