Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): hide description tooltip for tag edit mode #19463

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(ui): hide description tooltip for tag edit mode #19463

wants to merge 5 commits into from
+18 −8

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Jan 21, 2025 •
edited
Loading

Describe your changes:

Fix #19434

Hide the Tooltip containing tag description in EDIT mode, because it was masking the tags dropdown.

Before:
Screenshot 2025-01-21 at 3 57 24 PM

After:
Screenshot 2025-01-21 at 3 56 12 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 changed the title fix: hide description tooltip for tag edit mode fix(UI): hide description tooltip for tag edit mode Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 marked this pull request as ready for review January 21, 2025 11:35
@pranita09 pranita09 requested a review from a team as a code owner January 21, 2025 11:35
@pranita09 pranita09 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.65% (40875/63221) 40.9% (16421/40151) 44.11% (4969/11266)

chirag-madlani
chirag-madlani reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranita09 it won't render tooltip for non-edit mode as well right?

@pranita09 pranita09 marked this pull request as draft January 22, 2025 05:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pranita09 pranita09 marked this pull request as ready for review January 24, 2025 06:53
@pranita09 pranita09 changed the title fix(UI): hide description tooltip for tag edit mode fix(ui): hide description tooltip for tag edit mode Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the UI/UX in the Tag Edit Mode
2 participants
@pranita09 @chirag-madlani