[WIP] FIX 19311: New DI Email Template Implementation #19436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siddhanttimeline
added
the
safe to test
Siddhanttimeline
had a problem deploying
to
test
GitHub Actions
Failure
Siddhanttimeline
added
the
To release
Siddhanttimeline
had a problem deploying
to
test
GitHub Actions
Failure
Siddhanttimeline
changed the title
Siddhanttimeline
had a problem deploying
to
test
GitHub Actions
Failure
Siddhanttimeline
had a problem deploying
to
test
GitHub Actions
Failure
Siddhanttimeline
had a problem deploying
to
test
GitHub Actions
Failure
|
TeddyCr
reviewed
Jan 23, 2025
Comment on lines
+227
to
+229
| // data for that previous Monday–Sunday window | ||
| Map<String, Double> prevWeekDateWithCount = | ||
| getDateMapWithCountFromChart("total_data_assets", previousWeekStart, previousWeekEnd, team); |
There was a problem hiding this comment.
Does it mean we always compare to the previous (vs last 7 days).
e.g.
I get an alert on Wednesday, then the comparison will happen between Last Week (Monday - Sunday) vs Current Week (Monday - Tuesday)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #19311
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>