Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close select dropdpwn when focus is shifted to parent component #18992

Closed
wants to merge 5 commits into from
Closed

fix: close select dropdpwn when focus is shifted to parent component #18992

wants to merge 5 commits into from
+267 −97

Conversation

Kenil27
Copy link
Contributor

@Kenil27 Kenil27 commented Dec 10, 2024 •
edited by sweta1308
Loading

Describe your changes:

Issue: if user goes to edit a tag, glossary and navigate to a different tab before cancelling or validating it does not close the dropdown men

Fix:

Screen.Recording.2024-12-10.at.8.51.42.PM.mov

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@aniketkatkar97 aniketkatkar97 added the safe to test Add this label to run secure Github workflows on PRs label Dec 10, 2024
@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.52% (41222/63891) 40.87% (16594/40599) 44.11% (5020/11380)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
78.9% Duplication on New Code

See analysis details on SonarQube Cloud

@Kenil27 Kenil27 marked this pull request as draft December 12, 2024 08:39
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
78.9% Duplication on New Code

See analysis details on SonarQube Cloud

@sweta1308 sweta1308 marked this pull request as ready for review February 6, 2025 12:02
@sweta1308 sweta1308 requested a review from a team as a code owner February 6, 2025 12:02
@sweta1308 sweta1308 closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kenil27 @aniketkatkar97 @sweta1308