Fix Duplicate table constraints (#19502)

open-metadata · Jan 24, 2025 · 94ed7e3 · 94ed7e3
1 parent 1e7377c
commit 94ed7e3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/ingestion/src/metadata/ingestion/source/database/common_db_source.py b/ingestion/src/metadata/ingestion/source/database/common_db_source.py
@@ -683,7 +683,7 @@ def _get_foreign_constraints(
             foreign_constraint = self._prepare_foreign_constraints(
                 supports_database, column, table_name, schema_name, db_name, columns
             )
-            if foreign_constraint:
+            if foreign_constraint and foreign_constraint not in foreign_constraints:
                 foreign_constraints.append(foreign_constraint)
 
         return foreign_constraints
@@ -707,7 +707,11 @@ def update_table_constraints(
         )
         if foreign_table_constraints:
             if table_constraints:
-                table_constraints.extend(foreign_table_constraints)
+                table_constraints.extend(
+                    constraint
+                    for constraint in foreign_table_constraints
+                    if constraint not in table_constraints
+                )
             else:
                 table_constraints = foreign_table_constraints
         return table_constraints

diff --git a/ingestion/src/metadata/ingestion/source/database/sql_column_handler.py b/ingestion/src/metadata/ingestion/source/database/sql_column_handler.py
@@ -226,12 +226,16 @@ def get_columns_and_constraints(  # pylint: disable=too-many-locals
             if len(col) == 1:
                 column_level_unique_constraints.add(col[0])
             else:
-                table_constraints.append(
-                    TableConstraint(
-                        constraintType=ConstraintType.UNIQUE,
-                        columns=col,
+                if not any(
+                    tc.constraintType == ConstraintType.UNIQUE and tc.columns == col
+                    for tc in table_constraints
+                ):
+                    table_constraints.append(
+                        TableConstraint(
+                            constraintType=ConstraintType.UNIQUE,
+                            columns=col,
+                        )
                     )
-                )
         if len(pk_columns) > 1:
             table_constraints.append(
                 TableConstraint(