Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added course category filtering menu to My Courses #76

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Added course category filtering menu to My Courses #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bf4d9dc
Add category filter menu in the User personal menu
mouneyrac May 9, 2017
3ca0485
added remote repo to mouneyrac/master and merged into snap/master
upats Jul 10, 2017
c85bcbe
inital fixes for porting less to sass
upats Jul 12, 2017
a9f0003
fixed x icon in category menu
upats Jul 12, 2017
f074f17
fixed positioning/display of menu x icon
upats Jul 12, 2017
f74a2be
minor spacing fix
upats Jul 12, 2017
8f36146
cleaned up .sass-cache
upats Jul 12, 2017
f19c6f0
cleaning up unrequired files
upats Jul 13, 2017
aaa7fb9
added todo for porting variables from less to sass
upats Jul 13, 2017
8b9447c
Merge branch 'master' of https://github.com/moodlerooms/moodle-theme_…
upats Jul 13, 2017
2999e9a
Merge branch 'MOODLE_32_STABLE'
upats Jul 18, 2017
3d9048e
bumped version
upats Jul 18, 2017
da22d23
Add admin settings for personal menu category filter
mouneyrac Jul 28, 2017
21c48f5
synching with moodlerooms 32_STABLE branch
upats Jul 28, 2017
e04f862
fixed settings for new category filter toggle
upats Jul 28, 2017
d8fe98e
bumped version for new admin setting
upats Aug 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion amd/build/personal_menu.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions amd/build/pm_category_filter.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions amd/src/personal_menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
/**
* Course card favoriting.
*/
define(['jquery', 'core/log', 'core/yui', 'theme_snap/pm_course_cards', 'theme_snap/util', 'theme_snap/ajax_notification'],
function($, log, Y, courseCards, util, ajaxNotify) {
define(['jquery', 'core/log', 'core/yui', 'theme_snap/pm_course_cards', 'theme_snap/util', 'theme_snap/ajax_notification', 'theme_snap/pm_category_filter'],
function($, log, Y, courseCards, util, ajaxNotify, categoryFilter) {

/**
* Personal Menu (courses menu).
Expand Down Expand Up @@ -122,6 +122,10 @@ define(['jquery', 'core/log', 'core/yui', 'theme_snap/pm_course_cards', 'theme_s
var applyListeners = function() {
// On clicking personal menu trigger.
$(document).on("click", ".js-personal-menu-trigger", function(event) {
// TODO: in very rare case it may be possible that a different Snap code overlap the css set in the
// TODO: following call. To fix it we need to move this call later.
categoryFilter.viewingMode("get");

$('body').toggleClass('snap-fixy-open');
if ($('.snap-fixy-open #primary-nav').is(':visible')) {
self.update();
Expand Down
Loading