Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: rename top-level lib folder to open_feature #90

Merged
merged 2 commits into from
Jan 26, 2024
Merged

chore!: rename top-level lib folder to open_feature #90

merged 2 commits into from
Jan 26, 2024

Conversation

maxveldink
Copy link
Member

This PR

BREAKING CHANGE: Since we've decided on OpenFeature as our top-level module name, we should follow the Ruby convention of separating the words with an underscore in the file name.

Related Issues

References #71

Follow-up Tasks

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60423be) 98.90% compared to head (c40715f) 98.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           6        6           
  Lines          91       91           
=======================================
  Hits           90       90           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxveldink maxveldink marked this pull request as ready for review January 18, 2024 13:50
@maxveldink maxveldink requested a review from a team as a code owner January 18, 2024 13:50
josecolella
josecolella previously approved these changes Jan 18, 2024
beeme1mr
beeme1mr previously approved these changes Jan 18, 2024
BREAKING CHANGE: Since we've decided on `OpenFeature` as our top-level module name, we should follow the Ruby convention of separating the words with an underscore in the file name.

Signed-off-by: Max VelDink <[email protected]>
@maxveldink maxveldink dismissed stale reviews from beeme1mr and josecolella via 9e97a4b January 19, 2024 14:16
@technicalpickles technicalpickles merged commit e1a9a01 into open-feature:main Jan 26, 2024
10 checks passed
@maxveldink maxveldink deleted the maxveldink/rename-to-open_feature branch January 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants