Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move OTEL hooks to the SDK #338

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

askpt
Copy link
Member

@askpt askpt commented Dec 31, 2024

Move OTEL hooks to the SDK

This pull request moves the OTEL hooks to the SDK, as discussed in the linked issue (#175). I also changed the unit tests to clean up some code. Finally, I moved the documentation.

Related Issues

Fixes #175

Notes

Implementation of Tracing and Metrics Hooks:

Follow-up Tasks

  • As mentioned in the Tracing Hook, we should use the new API method when we upgrade this repository is upgraded to dotnet 9. [1]
  • We should remove any reference in the other repository and mark the Nuget package as deprecated.

askpt added 10 commits December 31, 2024 10:04
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
@askpt askpt linked an issue Dec 31, 2024 that may be closed by this pull request
@askpt askpt changed the title Move OTEL hooks to the SDK feat: Move OTEL hooks to the SDK Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.01%. Comparing base (1b5a0a9) to head (41c915d).

Files with missing lines Patch % Lines
src/OpenFeature/Hooks/MetricsHook.cs 94.11% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   85.49%   86.01%   +0.52%     
==========================================
  Files          38       40       +2     
  Lines        1517     1595      +78     
  Branches      154      161       +7     
==========================================
+ Hits         1297     1372      +75     
  Misses        188      188              
- Partials       32       35       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
@askpt askpt marked this pull request as ready for review December 31, 2024 11:48
@askpt askpt requested a review from a team as a code owner December 31, 2024 11:48
@beeme1mr
Copy link
Member

beeme1mr commented Jan 6, 2025

Thanks for starting this PR but I think we should wait until this spec PR is merged before moving this hook to the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Promote OTel hooks from contrib to in-the-box
2 participants