Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Default Logging Hook #308

Merged
merged 12 commits into from
Jan 23, 2025
Merged
1 change: 1 addition & 0 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<PackageVersion Include="coverlet.msbuild" Version="6.0.3" />
<PackageVersion Include="FluentAssertions" Version="7.0.0" />
<PackageVersion Include="GitHubActionsTestLogger" Version="2.4.1" />
<PackageVersion Include="Microsoft.Extensions.Diagnostics.Testing" Version="9.0.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageVersion Include="NSubstitute" Version="5.3.0" />
<PackageVersion Include="SpecFlow" Version="3.9.74" />
Expand Down
13 changes: 13 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,19 @@ var value = await client.GetBooleanValueAsync("boolFlag", false, context, new Fl

The .NET SDK uses Microsoft.Extensions.Logging. See the [manual](https://learn.microsoft.com/en-us/dotnet/core/extensions/logging?tabs=command-line) for complete documentation.

#### Logging Hook

The .NET SDK includes a LoggingHook, which logs detailed information at key points during flag evaluation, using Microsoft.Extensions.Logging structured logging API. This hook can be particularly helpful for troubleshooting and debugging; simply attach it at the global, client or invocation level and ensure your log level is set to "debug".

```csharp
using var loggerFactory = LoggerFactory.Create(builder => builder.AddConsole());
var logger = loggerFactory.CreateLogger("Program");

var client = Api.Instance.GetClient();
client.AddHooks(new LoggingHook(logger));
```
See [hooks](#hooks) for more information on configuring hooks.

### Domains

Clients can be assigned to a domain.
Expand Down
174 changes: 174 additions & 0 deletions src/OpenFeature/Hooks/LoggingHook.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,174 @@
using System;
using System.Collections.Generic;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Logging;
using OpenFeature.Model;

namespace OpenFeature.Hooks
{
/// <summary>
/// The logging hook is a hook which logs messages during the flag evaluation life-cycle.
/// </summary>
public sealed partial class LoggingHook : Hook
{
private readonly ILogger _logger;
private readonly bool _includeContext;

/// <summary>
/// Initialise a <see cref="LoggingHook"/> with a <paramref name="logger"/> and optional Evaluation Context. <paramref name="includeContext"/> will
/// include properties in the <see cref="HookContext{T}.EvaluationContext"/> to the generated logs.
/// </summary>
public LoggingHook(ILogger logger, bool includeContext = false)
{
this._logger = logger ?? throw new ArgumentNullException(nameof(logger));
this._includeContext = includeContext;
}

/// <inheritdoc/>
public override ValueTask<EvaluationContext> BeforeAsync<T>(HookContext<T> context, IReadOnlyDictionary<string, object>? hints = null, CancellationToken cancellationToken = default)
{
var evaluationContext = this._includeContext ? context.EvaluationContext : null;

var content = new LoggingHookContent(
context.ClientMetadata.Name,
context.ProviderMetadata.Name,
context.FlagKey,
context.DefaultValue?.ToString(),
evaluationContext);

this.HookBeforeStageExecuted(content);

return base.BeforeAsync(context, hints, cancellationToken);
}

/// <inheritdoc/>
public override ValueTask ErrorAsync<T>(HookContext<T> context, Exception error, IReadOnlyDictionary<string, object>? hints = null, CancellationToken cancellationToken = default)
{
var evaluationContext = this._includeContext ? context.EvaluationContext : null;

var content = new LoggingHookContent(
context.ClientMetadata.Name,
context.ProviderMetadata.Name,
context.FlagKey,
context.DefaultValue?.ToString(),
evaluationContext);

this.HookErrorStageExecuted(content);

return base.ErrorAsync(context, error, hints, cancellationToken);
}

/// <inheritdoc/>
public override ValueTask AfterAsync<T>(HookContext<T> context, FlagEvaluationDetails<T> details, IReadOnlyDictionary<string, object>? hints = null, CancellationToken cancellationToken = default)
{
var evaluationContext = this._includeContext ? context.EvaluationContext : null;

var content = new LoggingHookContent(
context.ClientMetadata.Name,
context.ProviderMetadata.Name,
context.FlagKey,
context.DefaultValue?.ToString(),
evaluationContext);

this.HookAfterStageExecuted(content);

return base.AfterAsync(context, details, hints, cancellationToken);
}

[LoggerMessage(
Level = LogLevel.Debug,
Message = "Before Flag Evaluation {Content}")]
partial void HookBeforeStageExecuted(LoggingHookContent content);

[LoggerMessage(
Level = LogLevel.Error,
Message = "Error during Flag Evaluation {Content}")]
partial void HookErrorStageExecuted(LoggingHookContent content);

[LoggerMessage(
Level = LogLevel.Debug,
Message = "After Flag Evaluation {Content}")]
partial void HookAfterStageExecuted(LoggingHookContent content);

/// <summary>
/// Generates a log string with contents provided by the <see cref="LoggingHook"/>.
/// <para>
/// Specification for log contents found at https://github.com/open-feature/spec/blob/d261f68331b94fd8ed10bc72bc0485cfc72a51a8/specification/appendix-a-included-utilities.md#logging-hook
/// </para>
/// </summary>
internal class LoggingHookContent
{
private readonly string _domain;
private readonly string _providerName;
private readonly string _flagKey;
private readonly string _defaultValue;
private readonly EvaluationContext? _evaluationContext;

public LoggingHookContent(string? domain, string? providerName, string flagKey, string? defaultValue, EvaluationContext? evaluationContext = null)
{
this._domain = string.IsNullOrEmpty(domain) ? "missing" : domain!;
this._providerName = string.IsNullOrEmpty(providerName) ? "missing" : providerName!;
this._flagKey = flagKey;
this._defaultValue = string.IsNullOrEmpty(defaultValue) ? "missing" : defaultValue!;
this._evaluationContext = evaluationContext;
}

public override string ToString()
{
var stringBuilder = new StringBuilder();

stringBuilder.Append("Domain:");
stringBuilder.AppendLine(this._domain);

stringBuilder.Append("ProviderName:");
stringBuilder.AppendLine(this._providerName);

stringBuilder.Append("FlagKey:");
stringBuilder.AppendLine(this._flagKey);

stringBuilder.Append("DefaultValue:");
stringBuilder.AppendLine(this._defaultValue);

if (this._evaluationContext != null)
{
stringBuilder.AppendLine("Context:");
foreach (var kvp in this._evaluationContext.AsDictionary())
{
stringBuilder.Append('\t');
stringBuilder.Append(kvp.Key);
stringBuilder.Append(':');
stringBuilder.AppendLine(GetValueString(kvp.Value));
}
}

return stringBuilder.ToString();
}

static string? GetValueString(Value value)
{
if (value.IsNull)
return string.Empty;

if (value.IsString)
return value.AsString;

if (value.IsBoolean)
return value.AsBoolean.ToString();

if (value.IsNumber)
{
// Value.AsDouble will attempt to cast other numbers to double
// There is an implicit conversation for int/long to double
if (value.AsDouble != null) return value.AsDouble.ToString();
}

Check warning on line 165 in src/OpenFeature/Hooks/LoggingHook.cs

View check run for this annotation

Codecov / codecov/patch

src/OpenFeature/Hooks/LoggingHook.cs#L165

Added line #L165 was not covered by tests

if (value.IsDateTime)
return value.AsDateTime?.ToString("O");

return value.ToString();
}
}
}
}
Loading
Loading