fix: upgrade upload-artifact gh action to v4 (#1690)

## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request - [ ] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request:  - [ ] if you changed code inside an experiment, make sure you bump its version number  ## Description This upgrades the github upload-artifact action to v4 since v3 has been deprecated: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ We also upgrade the gh checkout action.
ooni · Feb 24, 2025 · df136ef · df136ef
1 parent 437e786
commit df136ef
Show file tree

Hide file tree

Showing 20 changed files with 81 additions and 81 deletions.
diff --git a/.github/workflows/alltests.yml b/.github/workflows/alltests.yml
@@ -12,7 +12,7 @@ jobs:
   test:
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Get GOVERSION content
         id: goversion

diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
@@ -16,7 +16,7 @@ jobs:
   build_android:
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -37,57 +37,57 @@ jobs:
 
       - run: make android
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: oonimkall.aar
           path: ./MOBILE/android/oonimkall.aar
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: oonimkall-sources.jar
           path: ./MOBILE/android/oonimkall-sources.jar
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: oonimkall.pom
           path: ./MOBILE/android/oonimkall.pom
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: miniooni-android-386
           path: ./CLI/miniooni-android-386
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: ooniprobe-android-386
           path: ./CLI/ooniprobe-android-386
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: miniooni-android-amd64
           path: ./CLI/miniooni-android-amd64
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: ooniprobe-android-amd64
           path: ./CLI/ooniprobe-android-amd64
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: miniooni-android-arm
           path: ./CLI/miniooni-android-arm
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: ooniprobe-android-arm
           path: ./CLI/ooniprobe-android-arm
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: miniooni-android-arm64
           path: ./CLI/miniooni-android-arm64
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: ooniprobe-android-arm64
           path: ./CLI/ooniprobe-android-arm64
@@ -98,7 +98,7 @@ jobs:
     permissions:
       contents: write
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/build_docs.yml b/.github/workflows/build_docs.yml
@@ -6,7 +6,7 @@ jobs:
     runs-on: "ubuntu-20.04"
     steps:
       - name: Check out repository code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Build docs
         run: make docs

diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -11,7 +11,7 @@ jobs:
       matrix:
         os: [ "ubuntu-22.04" ]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -22,7 +22,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v2

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Get GOVERSION content
         id: goversion

diff --git a/.github/workflows/debianrepo.yml b/.github/workflows/debianrepo.yml
@@ -11,27 +11,27 @@ jobs:
   test_386:
     runs-on: "ubuntu-22.04"
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - run: sudo ./E2E/debian.bash docker i386
       - run: sudo cat DEBIAN_INSTALLED_PACKAGE.txt
 
   test_amd64:
     runs-on: "ubuntu-22.04"
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - run: sudo ./E2E/debian.bash docker amd64
       - run: sudo cat DEBIAN_INSTALLED_PACKAGE.txt
 
   test_arm:
     runs-on: "ubuntu-22.04"
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - run: sudo ./E2E/debian.bash docker armhf
       - run: sudo cat DEBIAN_INSTALLED_PACKAGE.txt
 
   test_arm64:
     runs-on: "ubuntu-22.04"
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - run: sudo ./E2E/debian.bash docker arm64
       - run: sudo cat DEBIAN_INSTALLED_PACKAGE.txt
diff --git a/.github/workflows/generate.yml b/.github/workflows/generate.yml
@@ -10,7 +10,7 @@ jobs:
   test:
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Get GOVERSION content
         id: goversion

diff --git a/.github/workflows/go1.22.yml b/.github/workflows/go1.22.yml
@@ -12,7 +12,7 @@ jobs:
   test:
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: magnetikonline/action-golang-cache@v4
         with:

diff --git a/.github/workflows/gobash.yml b/.github/workflows/gobash.yml
@@ -34,7 +34,7 @@ jobs:
         system: [ubuntu-latest]
     runs-on: "${{ matrix.system }}"
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: actions/setup-go@v4
         with:

diff --git a/.github/workflows/gosec.yml b/.github/workflows/gosec.yml
@@ -14,7 +14,7 @@ jobs:
         GO111MODULE: on
     steps:
     - name: Checkout Source
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Get GOVERSION content
       id: goversion

diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml
@@ -16,7 +16,7 @@ jobs:
   build_ios_mobile:
     runs-on: macos-12
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -40,62 +40,62 @@ jobs:
 
       - run: make EXPECTED_XCODE_VERSION=14.2 ios
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libcrypto.xcframework.zip
           path: ./MOBILE/ios/libcrypto.xcframework.zip
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libcrypto.podspec
           path: ./MOBILE/ios/libcrypto.podspec
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libevent.xcframework.zip
           path: ./MOBILE/ios/libevent.xcframework.zip
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libevent.podspec
           path: ./MOBILE/ios/libevent.podspec
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libssl.xcframework.zip
           path: ./MOBILE/ios/libssl.xcframework.zip
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libssl.podspec
           path: ./MOBILE/ios/libssl.podspec
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libtor.xcframework.zip
           path: ./MOBILE/ios/libtor.xcframework.zip
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libtor.podspec
           path: ./MOBILE/ios/libtor.podspec
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libz.xcframework.zip
           path: ./MOBILE/ios/libz.xcframework.zip
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: libz.podspec
           path: ./MOBILE/ios/libz.podspec
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: oonimkall.xcframework.zip
           path: ./MOBILE/ios/oonimkall.xcframework.zip
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: oonimkall.podspec
           path: ./MOBILE/ios/oonimkall.podspec
@@ -106,7 +106,7 @@ jobs:
     permissions:
       contents: write
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/libtorlinux.yml b/.github/workflows/libtorlinux.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Get GOVERSION content
         id: goversion