Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ain Ghazal <[email protected]>
  • Loading branch information
bassosimone and ainghazal authored Jan 16, 2024
1 parent 958a8fa commit 4f30abb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/libtor/enabled.go
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ func (p *torProcess) runtor(ctx context.Context, cc net.Conn, args ...string) {
code = C.tor_run_main(config)
} else {
// when simulating nonzero exit code we also want to sleep for a bit
// of time, to make sure we're able to see overalapped runs.
// of time, to make sure we're able to see overlapped runs.
code = 1
time.Sleep(time.Second)
}
Expand Down
2 changes: 1 addition & 1 deletion internal/libtor/enabled_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ func TestControlConnectionExplicitlyClosed(t *testing.T) {
// This test ensures that we cannot make concurrent calls to the library.
func TestConcurrentCalls(t *testing.T) {
// we need to simulate non zero exit code here such that we're not
// actually hitting into the real tor library; by doing this we would
// actually hitting into the real tor library; by doing this we
// make the test faster and reduce the risk of triggering the
// https://github.com/ooni/probe/issues/2406 bug caused by the
// fact we're invoking tor multiple times.
Expand Down

0 comments on commit 4f30abb

Please sign in to comment.