Don't leave back stray library after tests #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new test `test_library_update_with_initialize` introduced in olofk#720 did use the `fusesoc_libraries`-directory in the repository root and, in contrast to other tests in that module, did not delete it afterwards. This causes a leftover library in the repository root after running the testsuite. This is unpleasant and a bug in the test. This commit fixes it by cloning into the temporary directory, which was already created for just this use-case.
|
That makes sense. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test
test_library_update_with_initializeintroduced in #720 did use thefusesoc_libraries-directory in the repository root and, in contrast to other tests in that module, did not delete it afterwards. This causes a leftover library in the repository root after running the testsuite. This is unpleasant and a bug in the test.This commit fixes it by cloning into the temporary directory, which was already created for just this use-case.