Treatment and Discharge Summary for Completed Encounters #11141

AdityaJ2305 · 2025-03-08T11:10:54Z

Proposed Changes

Mark as complete action should only be available for not completed ones
Treatment and Discharge Summary for Completed Encounters
Fixes: Hide action heading in encounter once its marked completed #11139

@ohcnetwork/care-fe-code-reviewers

Slack Thread
https://rebuildearth.slack.com/archives/C010GQBMFJ9/p1741385328945659

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA in Mobile Devices
Completion of QA in Desktop Devices

Summary by CodeRabbit

Refactor
- Streamlined the conditions controlling when alert pop-ups appear, enhancing consistency in user notifications.
- Simplified the logic for showing consultation buttons, ensuring they display reliably when enabled.

coderabbitai · 2025-03-08T11:11:02Z

Walkthrough

This pull request simplifies the conditional rendering logic in both the EncounterActions and PatientInfoCard components. The changes remove the dependency on checking the encounter’s status against a list of completed statuses, instead using only the disableButtons flag to determine whether to render content. The rendering of AlertDialogs in EncounterActions is now conditioned solely on the encounter status not being completed, and the consultation buttons in PatientInfoCard are rendered whenever buttons are not disabled. There were no changes to exported or public entities.

Changes

Files	Change Summary
`src/components/.../EncounterActions.tsx` `src/components/.../PatientInfoCard.tsx`	Simplified conditional rendering by removing `completedEncounterStatus` checks. Components now rely solely on the `disableButtons` flag for rendering elements.

Sequence Diagram(s)

sequenceDiagram
    participant EA as EncounterActions
    participant DS as disableButtons Flag
    participant ES as Encounter Status
    participant AD as AlertDialog

    EA->>DS: Check disableButtons
    alt Buttons enabled
        EA->>ES: Evaluate encounter status
        alt Status not completed
            EA->>AD: Render AlertDialog
        else
            EA-->>AD: Do not render AlertDialog
        end
    else
        EA->>EA: Do not render content
    end

sequenceDiagram
    participant PIC as PatientInfoCard
    participant DS as disableButtons Flag
    participant Btn as Consultation Buttons

    PIC->>DS: Check disableButtons
    alt Buttons enabled
        PIC->>Btn: Render Consultation Buttons
    else
        PIC-->>Btn: Omit Consultation Buttons
    end

Possibly related PRs

Encounter Info Card #10792: The changes in this PR modify the conditional rendering logic based on the disableButtons flag, affecting the visibility of UI components similarly.
Added plug hook PatientInfoCardMarkAsComplete #10641: This PR involves modifications to the conditional rendering logic in the PatientInfoCard component, specifically regarding how components are displayed based on the encounter status.
Added confirmation before marking encounter as complete #10523: This PR includes changes to the conditional rendering logic of components that handle encounter statuses, affecting how user interactions with the AlertDialog are managed.

Suggested labels

needs review, tested

Suggested reviewers

rithviknishad
bodhish

Poem

I’m a bunny coding by the moon,
Hopping through logic, a joyful tune.
Buttons now show with a simple flag’s light,
AlertDialogs glisten in the clear night.
With each line refined in our code’s sweet land,
I celebrate the change with a gentle hop and a smile! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cf39d6 and 648a058.

📒 Files selected for processing (1)

src/components/Encounter/EncounterActions.tsx (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Test
GitHub Check: cypress-run (1)
GitHub Check: OSSAR-Scan

🔇 Additional comments (4)

src/components/Encounter/EncounterActions.tsx (4)

75-77: Clean simplification of the rendering condition.

The condition has been simplified to only check disableButtons instead of also checking the encounter status. This change aligns with the overall approach of controlling visibility through the disableButtons prop while handling specific action availability based on encounter status elsewhere in the component.

97-129: Properly restricting "Mark as complete" for incomplete encounters only.

Good implementation of the conditional rendering for the "Mark as complete" action in the dropdown menu. This ensures the action is only available when the encounter hasn't been completed yet, which aligns with the PR objective of restricting this action to encounters that haven't been completed.

160-196: Maintaining consistency in conditional rendering of actions.

The standalone version of the "Mark as complete" action follows the same conditional pattern as the dropdown version, ensuring consistency in behavior. This change correctly implements the requirement that this action should only be available for encounters that haven't been completed yet.

120-120: Recommendation about buttonVariants usage noted in previous review.

The previous review suggested simplifying the className to className={buttonVariants({ variant: "primary" })}, which is a valid suggestion for maintaining consistent code style.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-03-08T11:11:13Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`648a058`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67cdef2160423700084156a3
😎 Deploy Preview	https://deploy-preview-11141.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/components/Encounter/EncounterActions.tsx

…d_encounter

treatment and discharge summary for ended

2cf39d6

AdityaJ2305 requested a review from a team as a code owner March 8, 2025 11:10

abhimanyurajeesh reviewed Mar 9, 2025

View reviewed changes

src/components/Encounter/EncounterActions.tsx Outdated Show resolved Hide resolved

AdityaJ2305 added 3 commits March 10, 2025 01:09

rm cn

b06b2fb

Merge branch 'develop' into show_treatment_discharge_summary_for_ende…

a9800f1

…d_encounter

Empty-Commit

648a058

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Treatment and Discharge Summary for Completed Encounters #11141

Treatment and Discharge Summary for Completed Encounters #11141

AdityaJ2305 commented Mar 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 8, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Mar 8, 2025 •

edited

Loading

Treatment and Discharge Summary for Completed Encounters #11141

Are you sure you want to change the base?

Treatment and Discharge Summary for Completed Encounters #11141

Conversation

AdityaJ2305 commented Mar 8, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Mar 8, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Mar 8, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

AdityaJ2305 commented Mar 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Mar 8, 2025 •

edited

Loading