Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update organization navigation #11117

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update organization navigation #11117

wants to merge 1 commit into from
+10 −8

Conversation

abhimanyurajeesh
Copy link
Contributor

@abhimanyurajeesh abhimanyurajeesh commented Mar 7, 2025 •
edited by coderabbitai bot
Loading

Proposed Changes

Update organization navigation to default to users tab

  • Modify links in FacilityOrganizationIndex and FacilityOrganizationView to point to /departments/${org.id}/users
  • Reorder and update default tab in FacilityOrganizationLayout to prioritize users tab
  • Ensure consistent routing for organization-related pages

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA in Mobile Devices
  • Completion of QA in Desktop Devices

Summary by CodeRabbit

  • New Features
    • Navigation links now direct department pages to a dedicated user section, offering a more targeted experience.
    • The default view opens with the "users" tab, streamlining access to user information.
    • These valuable enhancements improve navigation clarity, simplify user management workflows, and contribute to a more intuitive interface for organization insights.

@abhimanyurajeesh abhimanyurajeesh requested a review from a team as a code owner March 7, 2025 12:11
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2025 •
edited
Loading

Walkthrough

This pull request updates the navigation paths within the Facility settings pages. The changes adjust the href attributes in Link components in both the organization index and view files, redirecting users from a general department page to a specific department users page. Additionally, the default tab in the organization layout is changed from "departments" to "users", ensuring the users view is prioritized upon component render. No public API declarations were altered.

Changes

File(s) Change Summary
src/pages/Facility/.../FacilityOrganizationIndex.tsx, src/pages/Facility/.../FacilityOrganizationView.tsx Modified the href in Link components from /departments/${org.id} to /departments/${org.id}/users to change the navigation target.
src/pages/Facility/.../components/FacilityOrganizationLayout.tsx Reordered navItems and updated currentTab default from "departments" to "users", changing the default tab selection.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LinkComponent
    participant Router
    participant Layout
    User->>LinkComponent: Click "See Details"
    LinkComponent->>Router: Navigate to /departments/{org.id}/users
    Router->>User: Render department users view
    Layout-->>User: Set default tab to "users"
Loading

Possibly related PRs

Suggested labels

tested, reviewed

Suggested reviewers

  • rithviknishad
  • Jacobjeevan

Poem

I'm a rabbit hopping through the code,
New paths gleam on every node.
Links now lead where users reside,
With a default tab set as our guide.
Hoppy changes make our journey bright!
🥕🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0837b8d and 61ea668.

📒 Files selected for processing (3)
  • src/pages/Facility/settings/organizations/FacilityOrganizationIndex.tsx (1 hunks)
  • src/pages/Facility/settings/organizations/FacilityOrganizationView.tsx (1 hunks)
  • src/pages/Facility/settings/organizations/components/FacilityOrganizationLayout.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: OSSAR-Scan
  • GitHub Check: cypress-run (1)
🔇 Additional comments (4)
src/pages/Facility/settings/organizations/FacilityOrganizationIndex.tsx (1)

230-230: Navigation path update looks good

This change aligns with the PR objective to modify navigation to default to the users tab. The link now directs to the users tab within the department view.

src/pages/Facility/settings/organizations/FacilityOrganizationView.tsx (1)

53-55: Link destination updated correctly

The navigation path update maintains consistency with the changes in FacilityOrganizationIndex.tsx, directing users to the users tab within the department view.

src/pages/Facility/settings/organizations/components/FacilityOrganizationLayout.tsx (2)

52-56: Navigation item organization looks good

The departments entry has been maintained in the navItems array, which is consistent with the existing navigation structure.

60-60: Default tab successfully changed to users

This change implements the core objective of the PR by making the users tab the default when no specific path is matched. This works well with the updated href attributes in the other files.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Mar 7, 2025 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 61ea668
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67cae283e690ab0008833927
😎 Deploy Preview https://deploy-preview-11117.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abhimanyurajeesh
Copy link
Contributor Author

@rithviknishad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@Jacobjeevan Jacobjeevan Awaiting requested review from Jacobjeevan

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhimanyurajeesh @rithviknishad