Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments Tweak #5810

Closed
wants to merge 3 commits into from
Closed

Comments Tweak #5810

wants to merge 3 commits into from

Conversation

FauziAkram
Copy link
Contributor

  • Remove from comments, hardcoded exact values for parameters that are subject to tuning.
  • Remove the Elo worth, as they are now completely outdated, making them irrelevant and potentially misleading.
  • Consolidated scaling-related comments into a single section for clarity. Used asterisks (*) to highlight parameters significantly affected by scaling, given their separation in the code.

Non-functional

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2025 •
edited
Loading

clang-format 18 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/noble/clang-format-18.

(execution 12857476904 / attempt 1)

@FauziAkram
Copy link
Contributor Author

P.S: If other parts are known as scalers that I missed, please point them out to me so I can update them.

@FauziAkram
bench: 1632964
04dfcaf 
bench: 1632964
@vondele vondele added no-functional-change to be merged Will be merged shortly labels Jan 25, 2025
@vondele vondele closed this in aa894c0 Jan 25, 2025
xu-shawn pushed a commit to xu-shawn/Stockfish that referenced this pull request Feb 2, 2025
@FauziAkram @xu-shawn
Comments Tweak
e1741db 
* Remove from comments, hardcoded exact values for parameters that are subject to tuning.
* Remove the Elo worth, as they are now completely outdated, making them irrelevant and potentially misleading.
* Consolidated scaling-related comments into a single section for clarity. Used asterisks (*) to highlight parameters significantly affected by scaling, given their separation in the code.

closes official-stockfish#5810

No functional change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xu-shawn xu-shawn xu-shawn left review comments

Assignees
No one assigned
Labels
no-functional-change to be merged Will be merged shortly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FauziAkram @xu-shawn @vondele