int distance<Rank>(Square x, Square y) #5787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify and optimize by reducing the number of operations. No functional change bench: 1379150
ces42
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Doesn't this produce the wrong output for B1 (x = 1) and A2 (y = 8)?
|x - y| = 7 and >> 3 then gives 0.
There was a problem hiding this comment.
Ooops. You are absolutely correct! I actually wrote some test code to test all the square combinations but it turns out the test code had a bug in it also. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and optimize
distance<Rank>(Square x, Square y)by reducing the number of operations.No functional change
bench: 1379150