Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize and Simplify Accumulator Updates #5759

Closed
wants to merge 2 commits into from
Closed

Optimize and Simplify Accumulator Updates #5759

wants to merge 2 commits into from

Conversation

xu-shawn
Copy link
Contributor

AMD Ryzen 5 7600X

sf_base =  1902646 +/-   2114 (95%)
sf_test =  1920873 +/-   2515 (95%)
diff    =    18227 +/-   3067 (95%)
speedup = 0.95800% +/- 0.161% (95%)

Passed Non-regression STC:
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 23072 W: 6041 L: 5813 D: 11218
Ptnml(0-2): 61, 2435, 6319, 2657, 64
https://tests.stockfishchess.org/tests/view/6780a0ca9168c8bf30927757

bench 999324

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2025 •
edited
Loading

clang-format 18 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/noble/clang-format-18.

(execution 12720198954 / attempt 1)

@xu-shawn
Update comment
2665052 
no functional change
@xu-shawn xu-shawn changed the title Simplify Accumulator Updates Speed Up and Simplify Accumulator Updates Jan 11, 2025
@xu-shawn xu-shawn changed the title Speed Up and Simplify Accumulator Updates Optimize and Simplify Accumulator Updates Jan 11, 2025
@Disservin
Copy link
Member

Ryzen 9 5950X

sf_base =  1413387 +/-   3592 (95%)
sf_test =  1437893 +/-   3355 (95%)
diff    =    24505 +/-   4669 (95%)
speedup = 1.73380% +/- 0.330% (95%)

@Torom
Copy link
Contributor

Torom commented Jan 11, 2025

Intel Core i7-6700K

sf_base =   912476 +/-   1863 (95%)
sf_test =   921864 +/-   2042 (95%)
diff    =     9388 +/-   3333 (95%)
speedup = 1.02893% +/- 0.365% (95%)

Raspberry Pi 5

sf_base =   260993 +/-   1508 (95%)
sf_test =   262912 +/-   1746 (95%)
diff    =     1918 +/-   1221 (95%)
speedup = 0.73504% +/- 0.468% (95%)

@xu-shawn xu-shawn mentioned this pull request Jan 11, 2025
Closed
@Disservin Disservin added simplification A simplification patch to be merged Will be merged shortly labels Jan 11, 2025
@Disservin Disservin closed this in 8d517bd Jan 12, 2025
vondele pushed a commit to vondele/Stockfish that referenced this pull request Jan 25, 2025
@xu-shawn @vondele
simplify accumulator updates
62ecdfe 
After official-stockfish#5759 accumulator updates are strictly on a per-move basis. Therefore, the generic code for updating multiple moves at once is no longer needed.

Passed Non-regression STC:
LLR: 3.00 (-2.94,2.94) <-1.75,0.25>
Total: 81696 W: 21204 L: 21039 D: 39453
Ptnml(0-2): 210, 8431, 23416, 8566, 225
https://tests.stockfishchess.org/tests/view/67823a24a31c4c13e83518a8

closes official-stockfish#5760

no functional change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
simplification A simplification patch to be merged Will be merged shortly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xu-shawn @Disservin @Torom