Simplify away hint for common parent position at probcut #5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passed non-regression test at STC https://tests.stockfishchess.org/tests/view/675fe27986d5ee47d9542d86 LLR: 2.93 (-2.94,2.94) <-1.75,0.25> Total: 118656 W: 30732 L: 30609 D: 57315 Ptnml(0-2): 319, 12767, 33049, 12858, 335 no functional change bench: 999324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's introduction at probcut step the nnue network has changed substantially
and now it no longer seems useful.
Passed non-regression test at STC
https://tests.stockfishchess.org/tests/view/675fe27986d5ee47d9542d86
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 118656 W: 30732 L: 30609 D: 57315
Ptnml(0-2): 319, 12767, 33049, 12858, 335
N.B.: It may be useful to reintroduce it here at probcut if we know that a node that was cut away previously now has to be explored. Exploring new ground will deliver no tt-hits so in this case the hint for common parent position might be useful.
no functional change
bench: 999324