Small cleanup of nnue_feature_transformer.h #5745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that sizeof(std::uint_fast8_t) is 1 byte which usually performs worse than int on modern 32 or 64 bit machines. What about std::uint_fast32_t or just leaving it as is? |
xu-shawn
force-pushed
the
cleanup_feature_transformer
branch
from
1a96f92 to
86b7ee6
Compare
|
done. would a re-test be needed? |
|
Still on lines 773 & 782. |
xu-shawn
force-pushed
the
cleanup_feature_transformer
branch
from
86b7ee6 to
b1eb8ce
Compare
|
i don't see a particular need to introduce a new type for loop variables |
xu-shawn
force-pushed
the
cleanup_feature_transformer
branch
from
b1eb8ce to
3377f14
Compare
bench 1294909
xu-shawn
force-pushed
the
cleanup_feature_transformer
branch
from
3377f14 to
2f2c973
Compare
Disservin
reviewed
Jan 5, 2025
| @@ -146,10 +146,10 @@ using psqt_vec_t = int32x4_t; | |||
| #endif | |||
|
|
|||
|
|
|||
| // Compute optimal SIMD register count for feature transformer accumulation. | |||
| template<IndexType TransformedFeatureWidth, IndexType HalfDimensions> | |||
| class SIMDTiling { | |||
There was a problem hiding this comment.
mh i dunno about making a this a class, i don't really a see a need to extrac this here
There was a problem hiding this comment.
also if VECTOR isn't defined we will just have an empty class?
There was a problem hiding this comment.
also if VECTOR isn't defined we will just have an empty class?
Yeah. the goal was to remove as much preprocessors directives from the main logic as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed Non-regression STC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 285760 W: 73716 L: 73768 D: 138276
Ptnml(0-2): 777, 30775, 79851, 30677, 800
https://tests.stockfishchess.org/tests/view/676f78681a2f267f205485aa
bench 1294909