[IMP] l10n_spain: update FACe configuration #11775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
auva-odoo
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Thank you @dade-odoo for your work! I just have one tiny comment so I'm going to go ahead and approve this PR already? You can r+ when you've made the change (or not) and all checks have passed.
Thanks again!
@robodoo delegate+
Comment on lines
156
to
157
| #. Complete the fields, including the file of the :guilabel:`Certificate` provided by the tax agency | ||
| and the provided :guilabel:`Certificate Password`. |
There was a problem hiding this comment.
Maybe nitpicking, but I would maybe mention the fact that we need to upload the file?
Update configration as the location of the config changed in 18.0. task-4327068
dade-odoo
force-pushed
the
18.0-accounting-spain-face-dade
branch
from
e995d74 to
b5b1372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update configuration as the location of the config changed in 18.0.
task-4327068