-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] accounting/l10n_ar: purchase withholding automation #11770
base: 18.0
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -45,6 +45,9 @@ localization: | |||||||||
- `l10n_ar_website_sale` | ||||||||||
- (optional) Allows the user to see Identification Type and AFIP Responsibility in the | ||||||||||
eCommerce checkout form in order to create electronic invoices. | ||||||||||
* - :ref:`Argentina - Payment Withholdings <l10n_ar/payment-withholdings>` | ||||||||||
- `l10n_ar_withholding` | ||||||||||
- Allows to register withholdings during the payment of an invoice. | ||||||||||
|
||||||||||
.. _argentina/configure-your-company: | ||||||||||
|
||||||||||
|
@@ -678,6 +681,147 @@ the invoice can then be validated. | |||||||||
:align: center | ||||||||||
:alt: Enter the perception amount. | ||||||||||
|
||||||||||
.. _l10n_ar/payment-withholdings: | ||||||||||
|
||||||||||
Withholding management | ||||||||||
---------------------- | ||||||||||
|
||||||||||
The Argentinean fiscal localization module is already loaded with the necessary withholdings | ||||||||||
records, which can be seen by navigating to :menuselection:`Accounting app --> Configuration --> | ||||||||||
Taxes`. To verify these records, the **Argentina Payment Withholdings** (`l10n_ar_withholding`) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
module must be :ref:`installed <general/install>`: | ||||||||||
|
||||||||||
Journal entries are *not* created when payments are posted until outstanding accounts are set up. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
Thus, for this feature to work properly, it is important to verify that *all* payment methods within | ||||||||||
the bank journals have an outstanding payment and receipt account set. | ||||||||||
|
||||||||||
.. image:: argentina/l10n-ar-outstanding-payments.png | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an example of a useful screenshot for a few reasons:
It does more than just show that something exists. The other screenshots in this section don't, so let's remove them. Especially with these really long localization pages, we're just creating a huge amount of unnecessary work to maintain the screenshots when there are minor UI updates in future versions. |
||||||||||
:alt: An outstanding payment account must be set. | ||||||||||
|
||||||||||
This configuration is crucial for the proper accounting of withholding transactions with clients | ||||||||||
and vendors. | ||||||||||
|
||||||||||
Configuration | ||||||||||
~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
As mentioned, Odoo already creates most of the required withholdings inside the :guilabel:`Taxes` | ||||||||||
menu. In several cases, it is necessary to apply or modify certain configurations to correctly | ||||||||||
Comment on lines
+707
to
+708
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
calculate the withholding amount on vendor payments. The current withholding types available are: | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
- :ref:`Earnings <l10n_ar/earnings-withholdings>` | ||||||||||
- :ref:`Earnings Scale <l10n_ar/earnings-scale-withholdings>` | ||||||||||
- :ref:`IIBB Total Amount <l10n_ar/iib-total-amount-withholdings>` | ||||||||||
- :ref:`IIBB Non-Taxable <l10n_ar/iib-nontax-withholdings>` | ||||||||||
|
||||||||||
.. _l10n_ar/earnings-withholdings: | ||||||||||
|
||||||||||
Earnings withholdings | ||||||||||
********************* | ||||||||||
Comment on lines
+718
to
+719
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
For :guilabel:`Earnings` withholdings, Odoo already has a record for each regime group, which is | ||||||||||
stated under the name of the tax and the AFIP code. | ||||||||||
|
||||||||||
Each of these records are ready to be used. As a good practice, the configuration should be double | ||||||||||
checked to make sure the configuration is updated and well-applied. The fields to validate are: | ||||||||||
|
||||||||||
- :guilabel:`Amount`: This is the percentage of the total payment amount which is withheld. | ||||||||||
- :guilabel:`Non-Taxable Amount`: Up to this amount, the withholding does not apply. | ||||||||||
- :guilabel:`Minimum Withholding`: If the calculated withholding amount is smaller than this value, | ||||||||||
the total withholding amount is set to `0.0`. | ||||||||||
- :guilabel:`Withholding Sequence`: This field helps to automate the capture of a withholding number | ||||||||||
under the payment line. If this field is not set, a number is manually captured while adding a | ||||||||||
withholding to a payment. | ||||||||||
Comment on lines
+724
to
+733
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does all of this apply only to Earnings withholdings? It seems like it's the standard that you're using for all four withholding types. If that's the case, it would make more sense to put it in the Configuration section so that it's not isolated under only one withholding type but meant to be referenced for all of them. It could come after the list of all four withholding types with something like the following:
|
||||||||||
|
||||||||||
.. image:: argentina/l10n-ar-earnings.png | ||||||||||
:alt: Earnings withholding type. | ||||||||||
|
||||||||||
.. _l10n_ar/earnings-scale-withholdings: | ||||||||||
|
||||||||||
Earnings scale withholdings | ||||||||||
*************************** | ||||||||||
Comment on lines
+740
to
+741
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Let's use the actual M2O names for the headings |
||||||||||
|
||||||||||
In this particular case, a percentage does not need to be set. However, this withholding is | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
calculated based on the :guilabel:`Scale` related to this field. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
.. image:: argentina/l10n-ar-earnings-scale.png | ||||||||||
:alt: Earnings Scales withholding type. | ||||||||||
|
||||||||||
Comment on lines
+746
to
+748
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
To view, modify, or create new scales, first activate :ref:`developer mode <developer-mode>` and | ||||||||||
then navigate to :menuselection:`Accounting app --> Configuration --> Earnings Scale`. By default, | ||||||||||
Comment on lines
+749
to
+750
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
From testing in runbot, it seems that developer mode isn't necessary |
||||||||||
Odoo comes loaded with two main scales. However, scales should be created and updated as necessary | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
to suit a business' needs. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I know it looks weird, but it's actually "business's" |
||||||||||
|
||||||||||
.. image:: argentina/l10n-ar-earnings-scale-1.png | ||||||||||
:alt: Earnings Scale table to modify if applicable. | ||||||||||
|
||||||||||
Comment on lines
+754
to
+756
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
.. note:: | ||||||||||
Earnings Scales are cumulative, which means that Odoo keeps track of the different records | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
created for a bill and automatically calculating the proper withholding amount. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
.. _l10n_ar/iib-total-amount-withholdings: | ||||||||||
|
||||||||||
IIBB total amount withholdings | ||||||||||
****************************** | ||||||||||
Comment on lines
+763
to
+764
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
In this case, the necessary records related to the applicable province need to be created. The | ||||||||||
withholding amount is calculated based on the amount (%) set on the tax configuration. Since Odoo | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
does not automatically synchronize the percentages applicable to each province, this information | ||||||||||
needs to be manually updated. | ||||||||||
|
||||||||||
.. image:: argentina/l10n-ar-total-amount-withholding.png | ||||||||||
:alt: Total Amount Withholding | ||||||||||
|
||||||||||
Comment on lines
+771
to
+773
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Comment on lines
+771
to
+773
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
The recommendation, in this case, is to always duplicate and apply the different configurations for | ||||||||||
each record to safeguard any technical configurations that allow the proper calculation and | ||||||||||
accounting of the withholding. | ||||||||||
|
||||||||||
.. _l10n_ar/iib-nontax-withholdings: | ||||||||||
|
||||||||||
IIBB non-taxable withholding | ||||||||||
**************************** | ||||||||||
Comment on lines
+780
to
+781
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
The configuration of Non-Taxable Gross Income withholdings is very similar to that of a :ref:`total | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
amount withholding <l10n_ar/iib-total-amount-withholdings>`, so the :guilabel:`Amount (%)` in each | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
of the records needs to be maintained. However, Odoo comes loaded with several records that apply to | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
different provinces. The difference, in this case, is that it is not necessary to establish a | ||||||||||
*Non-Taxable Amount* or *Minimum Withholding* for this record type. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
.. image:: argentina/l10n-ar-non-taxable.png | ||||||||||
:alt: Non Taxable | ||||||||||
|
||||||||||
Comment on lines
+789
to
+791
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
Partner withholding assignation | ||||||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
Once the proper configuration is set on each possible withholding for partners, the applicable | ||||||||||
withholdings need to be assigned to each contact. To do this, access the **Contacts** app and select | ||||||||||
the desired record. Then, find the :guilabel:`Purchase Withholdings` field in the | ||||||||||
:guilabel:`Accounting` tab. By default, only one withholding record is allowed for each type. | ||||||||||
However, by using the additional fields :guilabel:`Initial date` and :guilabel:`End date`, new | ||||||||||
withholding lines can be added of the same type with different date ranges. | ||||||||||
|
||||||||||
.. image:: argentina/l10n-ar-partner-assignation.png | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have a few issues here:
|
||||||||||
:alt: Partner assignation | ||||||||||
|
||||||||||
Automatic withholding calculation and application per payment | ||||||||||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
By applying new payments to vendor bills, Odoo automatically applies and calculates the proper | ||||||||||
withholding into the payment. Based on the record's configuration, it may be necessary to use a | ||||||||||
reference number for each withholding line. | ||||||||||
|
||||||||||
More withholdings can be added, or computed withholdings can be edited if necessary. | ||||||||||
|
||||||||||
.. image:: argentina/l10n-ar-payment.png | ||||||||||
:alt: Payment with applied withholdings. | ||||||||||
|
||||||||||
.. important:: | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like we're lacking a little bit of context for this information. Could you add just a brief explanation on the concept of how withholdings taxes work at the intro of the withholding management section? |
||||||||||
The total amount of the debt to be canceled is the total amount of the payment. However, Odoo | ||||||||||
still captures the net amount (i.e. the amount to be reconciled with the bank), which will be | ||||||||||
represented as the payment amount after the withholding application. | ||||||||||
|
||||||||||
.. image:: argentina/l10n-ar-payment-registered.png | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's resize this window a little bit so it's not so wide and retake the screenshot :) Instructions on different ways to do that if you need: https://www.odoo.com/documentation/master/contributing/documentation/content_guidelines.html#screenshots |
||||||||||
:alt: Payment Registered | ||||||||||
|
||||||||||
Check management | ||||||||||
---------------- | ||||||||||
|
||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.