Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validateDDO: getValidationSignature only for authentificated requests #835

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

validateDDO: getValidationSignature only for authentificated requests #835

wants to merge 14 commits into from

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Feb 4, 2025 •
edited
Loading

Fixes #816

Changes proposed in this PR:

  • On validateDDOCommand only getValidationSignature for authenticated requests
  • this requires changes at sdk level (and cli, if we publish with CLI) as we need to build/send a signature on the request
  • CLI and SDK related changes are addressed in separate PRs (system tests will fail until those are up to date)...
  • we need to merge: SDK -> CLI -> Nodes (in this order)
  • SDK PR add validate function signature changes, missing update docs and others ocean.js#1914

@paulo-ocean paulo-ocean self-assigned this Feb 4, 2025
@paulo-ocean
Copy link
Contributor Author

paulo-ocean commented Feb 5, 2025 •
edited
Loading

this is blocked by #826
needs support for AUTHORIZED_PUBLISHERS & AUTHORIZED_PUBLISHERS_LIST

@paulo-ocean
Copy link
Contributor Author

this is blocked by #826 needs support for AUTHORIZED_PUBLISHERS & AUTHORIZED_PUBLISHERS_LIST

unblocked now

@paulo-ocean paulo-ocean mentioned this pull request Feb 18, 2025
Open
@paulo-ocean
Copy link
Contributor Author

blocked again by oceanprotocol/ocean.js#1913

@paulo-ocean paulo-ocean changed the title wip: getValidationSignature only for authentificated requests validateDDO: getValidationSignature only for authentificated requests Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 will be requested when the pull request is marked ready for review alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas will be requested when the pull request is marked ready for review bogdanfazakas is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 will be requested when the pull request is marked ready for review jamiehewitt15 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina will be requested when the pull request is marked ready for review mariacarmina is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@paulo-ocean paulo-ocean

Labels
Status: Blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidateDDOCommand - getValidationSignature only for authentificated requests
1 participant
@paulo-ocean