Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination #31

Merged
merged 6 commits into from
Sep 16, 2024
Merged

feat: add pagination #31

merged 6 commits into from
Sep 16, 2024

Conversation

tom1145
Copy link
Collaborator

@tom1145 tom1145 commented Sep 11, 2024

Fixes #22.

Changes proposed in this PR:

  • added pagination to table

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodes-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 4:00pm

@bogdanfazakas
Copy link
Member

bogdanfazakas commented Sep 12, 2024

I have identified 2 thinks for the moment see points bellow:

  1. Before merging this we need to also update the logic and create a new context for the map & locations, because it displays only the nodes
Screenshot 2024-09-12 at 10 50 59 on the map received for the given page
  1. the results seem to be capped at 10k, but we have more than this number of nodes, but this may require changes to the incentive-backend
Screenshot 2024-09-12 at 10 55 20

@bogdanfazakas
Copy link
Member

I have identified 2 thinks for the moment see points bellow:

  1. Before merging this we need to also update the logic and create a new context for the map & locations, because it displays only the nodes on the map received for the given page
  1. the results seem to be capped at 10k, but we have more than this number of nodes, but this may require changes to the incentive-backend

think it we can also move fwd if we fix point 2 and address 1 with map & locations on a later pr

@tom1145
Copy link
Collaborator Author

tom1145 commented Sep 13, 2024

I have identified 2 thinks for the moment see points bellow:

  1. Before merging this we need to also update the logic and create a new context for the map & locations, because it displays only the nodes on the map received for the given page
  1. the results seem to be capped at 10k, but we have more than this number of nodes, but this may require changes to the incentive-backend

think it we can also move fwd if we fix point 2 and address 1 with map & locations on a later pr

I've made a fix now with totalItems and sort for uptime, can you please check it out? thanks!

<GridToolbarDensitySelector />
<GridToolbarExport />

<TextField
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would align all this elements related to search to the headers right , it should work with some align-items: flex-end i suppose

@bogdanfazakas bogdanfazakas merged commit f20ceeb into main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table pagination
3 participants