Use standard hash function for Z.hash
and add Z.seeded_hash
#150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with other integer types in the standard library (modules Int, Int32, Int64, Nativeint), let's use the standard hash function (
Hashtbl.hash
) forZ.hash
instead of our variant. This is a bit slower but has several benefits:While we're at it, add a
Z.seeded_hash
function, defined asHashtbl.seeded_hash
, so that theZ
module can be used as the argument to theHashtbl.MakeSeeded
functor.Also: improve documentation of
Z.hash
and add some more@since
tags.Closes #145 as this addresses the needs expressed in #145, while being more consistent with the OCaml stdlib modules.