Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GABAergic interneuron pSNpr aSNpr for BICAN Basal Ganglia #2600

Merged

Conversation

AvolaAmg
Copy link
Collaborator

Fixes #2577

@AvolaAmg AvolaAmg added Priority-High new term request HCA/DCP Needed/useful for the Human Cell Atlas BICAN labels Sep 23, 2024
@AvolaAmg AvolaAmg added this to the pre HCA meeting release milestone Sep 23, 2024
@AvolaAmg AvolaAmg self-assigned this Sep 23, 2024
@aleixpuigb
Copy link
Collaborator

#gogoeditdiff

Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-24/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-24/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

GABAergic interneuron of the anterior substantia nigra pars reticulata http://purl.obolibrary.org/obo/CL_4042023

Added

GABAergic interneuron of the posterior substantia nigra pars reticulata http://purl.obolibrary.org/obo/CL_4042024

Added

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

GABAergic interneuron of the anterior substantia nigra pars reticulata http://purl.obolibrary.org/obo/CL_4042023

Added

GABAergic interneuron of the posterior substantia nigra pars reticulata http://purl.obolibrary.org/obo/CL_4042024

Added

PR_000004691 http://purl.obolibrary.org/obo/PR_000004691

Added

PR_000013047 http://purl.obolibrary.org/obo/PR_000013047

Added

PR_000014898 http://purl.obolibrary.org/obo/PR_000014898

Added

Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR terms are not being imported, i am investigating why and I will approve once it is solved (the terms look good!)

@aleixpuigb
Copy link
Collaborator

I could import the PR terms but please solve all conflictits arised from using the same CL IDs than terms added in #2569

@AvolaAmg AvolaAmg requested a review from aleixpuigb September 24, 2024 13:59
@AvolaAmg AvolaAmg force-pushed the GABAergic-interneuron-pSNpr-aSNpr-for-BICAN-Basal-Ganglia branch from 65ab07f to 1510190 Compare September 24, 2024 14:12
aleixpuigb
aleixpuigb previously approved these changes Sep 24, 2024
@aleixpuigb
Copy link
Collaborator

I have used free IDs after the ones that are used in existing unmerged PR. Please, make sure that next time you add a term it is not using the IDs from these two terms.

@AvolaAmg AvolaAmg merged commit 8b7e41a into master Sep 25, 2024
1 check passed
@AvolaAmg AvolaAmg deleted the GABAergic-interneuron-pSNpr-aSNpr-for-BICAN-Basal-Ganglia branch September 25, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BICAN HCA/DCP Needed/useful for the Human Cell Atlas new term request Priority-High
Projects
Development

Successfully merging this pull request may close these issues.

[NTR] GABAergic interneuron pSNpr aSNpr for BICAN Basal Ganglia
2 participants