Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mge-derived-cortical-interneuron-hierarchy #2536

Merged
merged 16 commits into from
Sep 24, 2024

Conversation

AvolaAmg
Copy link
Collaborator

@AvolaAmg AvolaAmg commented Sep 2, 2024

fixes #2428

@Caroline-99
Copy link
Collaborator

#gogoeditdiff

@dosumis
Copy link
Contributor

dosumis commented Sep 17, 2024

Updated to use inferred classification #gogoeditdiff

@dosumis
Copy link
Contributor

dosumis commented Sep 17, 2024

@AvolaAmg - it would be good to add refs supporting MGE origin, + some note on evidence in comment. This will make it easier for future editors to understand and work with, as well as being potentially useful to users.

@dosumis
Copy link
Contributor

dosumis commented Sep 17, 2024

Also wondering what the status is on moving some of these to T-types - particularly SST CHODL to move out from under SST.

@Caroline-99
Copy link
Collaborator

#gogoeditdiff

Copy link

github-actions bot commented Sep 23, 2024

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-24/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-24/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

L2/3/5 fan Martinotti sst GABAergic interneuron (Mmus) http://purl.obolibrary.org/obo/CL_4023030

Removed

Added

L4 sst Martinotti interneuron (Mmus) http://purl.obolibrary.org/obo/CL_4023031

Removed

Added

L5 non-Martinotti sst GABAergic interneuron (Mmus) http://purl.obolibrary.org/obo/CL_4023028

Removed

Added

L5 sst T-Martinotti interneuron (Mmus) http://purl.obolibrary.org/obo/CL_4023027

Removed

Added

L5/6 non-Martinotti sst GABAergic interneuron (Mmus) http://purl.obolibrary.org/obo/CL_4023118

Removed

Added

L6 th sst GABAergic interneuron (Mmus) http://purl.obolibrary.org/obo/CL_4023075

Removed

Added

oxytocin receptor sst GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023122

Removed

Added

pvalb GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023018

Removed

Added

sst GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023017

Removed

Added

Copy link

github-actions bot commented Sep 23, 2024

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

chandelier pvalb GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023036

Added

medial ganglionic eminence derived GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023069

Added

pvalb GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023018

Removed

Added

sst GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023017

Removed

Added

sst chodl GABAergic cortical interneuron http://purl.obolibrary.org/obo/CL_4023121

Added

@Caroline-99
Copy link
Collaborator

@AvolaAmg The classification looks good. The only suggestion I have is to align the textual defs with the logical ones (if you want). ie. sst GABAergic cortical interneuron: A GABAergic neuron that develops from medial ganglionic eminence and is located in the cerebral cortex. The interneuron expresses somatostatin (sst) and secretes gamma-aminobutyric acid.

@AvolaAmg
Copy link
Collaborator Author

@Caroline-99 thank you Caroline! all done, see next commit!

@AvolaAmg
Copy link
Collaborator Author

#gogoeditdiff

@AvolaAmg AvolaAmg merged commit f68f363 into master Sep 24, 2024
1 check passed
@AvolaAmg AvolaAmg deleted the mge-derived-cortical-interneuron-hierarchy branch September 24, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Class hierarchy] CGE and MGE cortical interneurons have no children
3 participants