Fix tsv formatting and refresh imports #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace space characters with tabs in entity_attribute_location.tsv.
This commit intends to provide a short term fix for the issues caused by the obsoletion of the process term [aging GO:0007568](geneontology/go-announcements#502). Need to add back these terms once there are appropriate replacement terms for [GO:0007568](https://www.ebi.ac.uk/ols/ontologies/GO/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FGO_0007568). See related issue #239.
entity_attribute_location.tsv 198:OBA:VT0000203 blood aspartate transaminase amount PR:000008153 aspartate aminotransferase, cytoplasmic PATO:0000070 amount UBERON:0000178 blood 251:OBA:2060177 PR:000008153 aspartate aminotransferase, cytoplasmic PATO:0000070 amount UBERON:0000178 blood
matentzn
requested changes
Apr 28, 2023
The process of `aging GO:0007568` [has been obsoleted in GO.](geneontology/go-announcements#502). The affected OBA trait terms ``` OBA:0003870 OBA:0005494 ``` have been added back without EQs manually.
matentzn
requested changes
Apr 28, 2023
| id: OBA:0003870 | ||
| name: aging onset quality | ||
| def: "The onset quality of aging." [] | ||
| is_a: PATO:0002325 ! onset quality |
There was a problem hiding this comment.
parent must be an OBA term, else violates constraints
| id: OBA:0005494 | ||
| name: aging rate | ||
| def: "The rate of the aging process." [] | ||
| is_a: PATO:0000161 ! rate |
There was a problem hiding this comment.
parent must be an OBA term
There was a problem hiding this comment.
The large diff is caused by missing tab characters between empty cells in the tsv table in the last two columns in the master version of the tsv file. I am not sure if that is correct syntax for a tsv file, but somebody's text editor thought so. Anyway, I have decreased the diff by removing the tab characters from my version of the file.
to decrease the size of diff
…bute-ontology into fix_tsv2023-04-26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace space characters with tabs in entity_attribute_location.tsv.Remove OBA:2060177, because it is a duplicate of OBA:VT0000203. Removing OBA:2060177 also solves the tsv formatting issue.