Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace WebUtilLogService with LumberjackLoggers #2

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NachoVazquez
Copy link

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

A generic WebUtilLogService is used as a wrapper for the LumberjackService and use inline logs.

Issue Number: N/A

What is the new behavior?

Replaces the WebUtilLogService with specialized LumberjackLoggers encapsulating log creation and emission.

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

  • This is just an example created to show how the LumberjackLogger pattern fits with nxpm.
  • More PR draft related to this one will be created to show other variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant