feat: add more match for bufferline icons #1270
Conversation
|
Are these icons specific to mini.icon? Or do they exist in nvim-web-devicons? |
| elseif self.filetype == 'TelescopePrompt' then | ||
| dev, _ = require('nvim-web-devicons').get_icon('telescope') | ||
| dev, _ = require('nvim-web-devicons').get_icon_by_filetype('TelescopePrompt') | ||
| elseif self.filetype == 'fugitive' then |
There was a problem hiding this comment.
In fact, the original query statement does not work properly.
TelescopePrompt Never displays properly
|
nvim-web-devicons does not provide icons for these (maybe some do), but if nvim-web-devicons cannot be queried, it will return |
| @@ -38,12 +38,94 @@ function Buffer:get_props() | |||
| local status, _ = pcall(require, 'nvim-web-devicons') | |||
| if not status then | |||
| dev, _ = '', '' | |||
| elseif self.filetype == 'minideps-confirm' then | |||
There was a problem hiding this comment.
Can you put a comment at the start of these and at the end of these. stating the icons in this block exist in mini.icons (with link). and that it's relying on the fact that mini.icons patching nvim-web-devicons interface. Tbh this feels like an anti-pattern that they are patching other modules like this. I'm still not sure about relying on it like this. especially not without proper documentation.
There was a problem hiding this comment.
Maybe you are right, these adjustments can wait until the subsequent development of nvim-web-devicons or is lualine directly compatible with mini.icons?
No description provided.