Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usages of controlTypes.stateLabels and negativeStateLabels #12821

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Sep 9, 2021

Link to issue number:

Part of #12549

Summary of the issue:

controlTypes.stateLabels has been deprecated, usages such as controlTypes.stateLabels[controlTypes.State.*] should be replaced to their equivalent controlTypes.State.*.displayString

Description of how this pull request fixes the issue:

Use displayString and negativeDisplayString instead of stateLabels and negativeStateLabels.

Testing strategy:

Search the NVDA repo for "stateLabels" and "negativeStateLabels".

Unit tests exist in test_controlTypes.TestLabels (and have been renamed appropriately).

Known issues with pull request:

None

Change log entries:

None needed

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@seanbudd seanbudd merged commit da36a66 into master Sep 13, 2021
@seanbudd seanbudd deleted the remove-stateLabels branch September 13, 2021 00:20
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants