Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devtools): display file size in devtools #462

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qwerzl
Copy link
Member

@qwerzl qwerzl commented Jan 21, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@danielroe

Closes #460. Also includes some minor UI changes in order to fit the badge in.

Currently the file size is considered:

  • good if <30KB;
  • moderate if <100KB;
  • bad if >100KB.

@qwerzl qwerzl requested a review from danielroe as a code owner January 21, 2025 03:27
@qwerzl qwerzl changed the title feat: show file size in devtools feat(devtools): display file size in devtools Jan 21, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 82.08%. Comparing base (a90d7a0) to head (5e8db2c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files          13       13           
  Lines        1066     1066           
  Branches      287      287           
=======================================
  Hits          875      875           
  Misses        181      181           
  Partials       10       10           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display loaded/injected font size (in Mb)
2 participants