Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-T11-2] AgenSee #65

Open
wants to merge 714 commits into
base: master
Choose a base branch
from

Conversation

WJunHong
Copy link

This is the main PR for CS2103T-T11-2's master branch into AY2122S2/tp master branch

Team members:

  • Wang Jun Hong
  • Janald Ho
  • Bian Yuqi
  • Chua Shi Hong
  • Phua Jun Heng

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #65 (fa0004c) into master (4f7660a) will decrease coverage by 1.14%.
The diff coverage is 75.80%.

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
- Coverage     72.15%   71.01%   -1.15%     
- Complexity      399      879     +480     
============================================
  Files            70      141      +71     
  Lines          1232     2712    +1480     
  Branches        125      339     +214     
============================================
+ Hits            889     1926    +1037     
- Misses          311      644     +333     
- Partials         32      142     +110     
Impacted Files Coverage Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø)
src/main/java/seedu/address/model/client/Name.java 80.00% <ø> (ø)
...rc/main/java/seedu/address/model/client/Phone.java 80.00% <ø> (ø)
...s/model/client/PhoneContainsKeywordsPredicate.java 0.00% <0.00%> (ø)
...a/seedu/address/model/client/UniqueClientList.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/model/tag/Tag.java 80.00% <ø> (ø)
.../java/seedu/address/storage/JsonAdaptedClient.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/BuyerCard.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/BuyerListPanel.java 0.00% <0.00%> (ø)
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7660a...fa0004c. Read the comment docs.

janald99 and others added 29 commits April 6, 2022 18:32
Before, no explanation for weird inputs.

Now, we tell them how they will be interpreted. Also, update the index
styling.
Before, it wasn't clear what was an invalid index.

Now, it is clearer.
Before, some error messages were not formatted properly, and not clear
enough.

Now, they are clear and to the point.
More UG explanations, fix error messages
…into branch-bug-fix

# Conflicts:
#	src/main/java/seedu/address/commons/core/Messages.java
WJunHong and others added 30 commits April 11, 2022 21:31
update DG about Edit Buyer feature, Saving data section's format error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants