Remove Serving specific jetstream stream env variable

Signed-off-by: Sreekanth <[email protected]>
numaproj · Feb 3, 2025 · ec8ccd0 · ec8ccd0
1 parent 06fc738
commit ec8ccd0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/pkg/apis/numaflow/v1alpha1/vertex_types.go b/pkg/apis/numaflow/v1alpha1/vertex_types.go
@@ -364,7 +364,6 @@ func (v Vertex) GetPodSpec(req GetVertexPodSpecReq) (*corev1.PodSpec, error) {
 		containers[0].Env = append(
 			containers[0].Env,
 			// set the serving source stream name in the environment because the numa container will be reading from it
-			corev1.EnvVar{Name: EnvServingJetstreamStream, Value: req.ServingSourceStreamName},
 			corev1.EnvVar{Name: EnvServingMinPipelineSpec, Value: encodedPipelineSpec},
 			corev1.EnvVar{Name: EnvServingPort, Value: strconv.Itoa(VertexHTTPSPort)},
 			corev1.EnvVar{

diff --git a/pkg/apis/numaflow/v1alpha1/vertex_types_test.go b/pkg/apis/numaflow/v1alpha1/vertex_types_test.go
@@ -362,8 +362,7 @@ func TestGetPodSpec(t *testing.T) {
 		}
 		assert.ElementsMatch(t, envNames, []string{
 			"test-env", EnvNamespace, EnvPod, EnvPipelineName, EnvVertexName, EnvVertexObject, EnvReplica,
-			EnvCallbackEnabled, EnvServingMinPipelineSpec,
-			EnvServingHostIP, EnvServingPort, EnvServingJetstreamStream,
+			EnvCallbackEnabled, EnvServingMinPipelineSpec, EnvServingHostIP, EnvServingPort,
 		})
 
 		assert.Contains(t, s.Containers[0].Args, "processor")
@@ -620,7 +619,6 @@ func TestGetPodSpec(t *testing.T) {
 		assert.Contains(t, envNames, EnvPipelineName)
 		assert.Contains(t, envNames, EnvVertexName)
 		assert.Contains(t, envNames, EnvReplica)
-		assert.Contains(t, envNames, EnvServingJetstreamStream)
 		assert.Contains(t, envNames, EnvServingHostIP)
 		assert.Contains(t, envNames, EnvServingMinPipelineSpec)
 	})