-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove internal AWS SDK implementation #1030
Remove internal AWS SDK implementation #1030
Conversation
@smallhive @roman-khimov if try to add s3 gw from this PR to nexus, it fails like this:
if use s3 gw from master (same parameters in nexus), it fails like this:
So, it doesn't work in both cases, but errors are different. To reproduce:
|
This problem with the signature
is fixed with proper configuration
Then, the problem with PutBucketLifecycle:
Is fixed with
Then, the problem with GetBucketLifecycle:Here I hacked the response from not implemented to NoSuchLifecycleConfiguration. It is enough to go through this step. And
|
Closes #1029. Signed-off-by: Evgenii Baidakov <[email protected]>
Having our own implementation for AWS SDK lib looks like overkill. Signed-off-by: Evgenii Baidakov <[email protected]>
849a272
to
54ff7e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWSS3V4SignerType
is the key to me here. If it works, we're fine with this change. Other issues are... other issues.
Closes #1029