Skip to content

Commit

Permalink
PutBucketLogging is not implemented (#925)
Browse files Browse the repository at this point in the history
Closes #907.

GetBucketLogging already marked as not implemented
  • Loading branch information
roman-khimov authored Feb 8, 2024
2 parents bcc5e23 + 8ece55b commit 90de859
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions api/handler/unimplemented.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ func (h *handler) GetBucketLoggingHandler(w http.ResponseWriter, r *http.Request
h.logAndSendError(w, "not implemented", api.GetReqInfo(r.Context()), s3errors.GetAPIError(s3errors.ErrNotImplemented))
}

func (h *handler) PutBucketLoggingHandler(w http.ResponseWriter, r *http.Request) {
h.logAndSendError(w, "not implemented", api.GetReqInfo(r.Context()), s3errors.GetAPIError(s3errors.ErrNotImplemented))
}

func (h *handler) GetBucketReplicationHandler(w http.ResponseWriter, r *http.Request) {
h.logAndSendError(w, "not implemented", api.GetReqInfo(r.Context()), s3errors.GetAPIError(s3errors.ErrNotImplemented))
}
Expand Down
5 changes: 5 additions & 0 deletions api/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ type (
GetBucketAccelerateHandler(http.ResponseWriter, *http.Request)
GetBucketRequestPaymentHandler(http.ResponseWriter, *http.Request)
GetBucketLoggingHandler(http.ResponseWriter, *http.Request)
PutBucketLoggingHandler(http.ResponseWriter, *http.Request)
GetBucketReplicationHandler(http.ResponseWriter, *http.Request)
GetBucketTaggingHandler(http.ResponseWriter, *http.Request)
DeleteBucketWebsiteHandler(http.ResponseWriter, *http.Request)
Expand Down Expand Up @@ -363,6 +364,10 @@ func Attach(r *mux.Router, domains []string, m MaxClients, h Handler, center aut
bucket.Methods(http.MethodGet).HandlerFunc(
m.Handle(metrics.APIStats("getbucketlogging", h.GetBucketLoggingHandler))).Queries("logging", "").
Name("GetBucketLogging")
// PutBucketLoggingHandler -- this is a dummy call.
bucket.Methods(http.MethodPut).HandlerFunc(
m.Handle(metrics.APIStats("putbucketlogging", h.PutBucketLoggingHandler))).Queries("logging", "").
Name("PutBucketLogging")
// GetBucketLifecycleHandler -- this is a dummy call.
bucket.Methods(http.MethodGet).HandlerFunc(
m.Handle(metrics.APIStats("getbucketlifecycle", h.GetBucketLifecycleHandler))).Queries("lifecycle", "").
Expand Down

0 comments on commit 90de859

Please sign in to comment.