Add some helpers functions for testing purposes. #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallhive
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
smallhive
force-pushed
the
contracts-tests-helpers
branch
2 times, most recently
from
e016227 to
ded2737
Compare
smallhive
force-pushed
the
contracts-tests-helpers
branch
from
ded2737 to
06dedf0
Compare
I added tests |
smallhive
force-pushed
the
contracts-tests-helpers
branch
from
06dedf0 to
5d37c3c
Compare
cthulhu-rider
previously approved these changes
Sep 23, 2024
carpawell
reviewed
Sep 23, 2024
tests/deploys.go
Outdated
| } | ||
|
|
||
| func nnsContractInvoker(t *testing.T, e *neotest.Executor) *neotest.ContractInvoker { | ||
| nnsHash, err := e.Chain.GetContractScriptHash(1) |
There was a problem hiding this comment.
i think @roman-khimov prefers
neofs-contract/rpc/nns/hashes.go
Line 34 in db6dbb9
There was a problem hiding this comment.
So do I, but I have nothing to suggest as a ContractStateGetter for InferHash func.
There was a problem hiding this comment.
nns.ID is still relevant here.
There was a problem hiding this comment.
nothing to suggest as a ContractStateGetter for InferHash func
wasnt e.Chain good enough?
There was a problem hiding this comment.
Unfortunately no, neotest Chain is not good enough
smallhive
force-pushed
the
contracts-tests-helpers
branch
from
5d37c3c to
ca59b54
Compare
tests/deploys.go
Outdated
| } | ||
|
|
||
| func nnsContractInvoker(t *testing.T, e *neotest.Executor) *neotest.ContractInvoker { | ||
| nnsHash, err := e.Chain.GetContractScriptHash(1) |
There was a problem hiding this comment.
nns.ID is still relevant here.
smallhive
force-pushed
the
contracts-tests-helpers
branch
from
ca59b54 to
9f1b67a
Compare
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
contracts-tests-helpers
branch
from
9f1b67a to
2f07ada
Compare
roman-khimov
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.