zkpbinding: remove range usage from smartcontract #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3802 +/- ##
==========================================
+ Coverage 83.00% 83.07% +0.07%
==========================================
Files 336 336
Lines 47090 47090
==========================================
+ Hits 39089 39122 +33
+ Misses 6400 6363 -37
- Partials 1601 1605 +4 ☔ View full report in Codecov by Sentry. |
roman-khimov
reviewed
Feb 3, 2025
Reverting a part of 1b83dc2, because ranging over integers is not supported by smart contract compiler, ref. #3525. Signed-off-by: Ekaterina Pavlova <[email protected]>
This place was not updated with update_deps.sh. Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
range-int
branch
from
0c917e4 to
267d7dc
Compare
roman-khimov
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same situation as #3680.