Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDFS and GDPWR NRFS services and Zephyr implementations #2300

Merged
merged 12 commits into from
Dec 13, 2024
Merged

GDFS and GDPWR NRFS services and Zephyr implementations #2300

merged 12 commits into from
Dec 13, 2024

Conversation

bjarki-andreasen
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen commented Nov 26, 2024 •
edited
Loading

Blocked until WiFi changes have been merged nrfconnect/sdk-nrf#19147, and SDSC bundle is ready with GDSF and GDPWR services.

@NordicBuilder NordicBuilder mentioned this pull request Nov 26, 2024
Closed
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 26, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nordic zephyrproject-rtos/hal_nordic@54bde38 zephyrproject-rtos/hal_nordic@fae1542 (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@bjarki-andreasen bjarki-andreasen changed the title Pull in global hsfll clock device driver [WIP] Pull in global hsfll clock device driver Nov 26, 2024
@bjarki-andreasen bjarki-andreasen force-pushed the nordic-global-hsfll branch 3 times, most recently from 53dc701 to 9f6741b Compare November 27, 2024 21:01
@shanthanordic shanthanordic added this to the ncs-2.9.0 milestone Nov 29, 2024
@bjarki-andreasen bjarki-andreasen force-pushed the nordic-global-hsfll branch 2 times, most recently from 8673de1 to 83164e5 Compare November 29, 2024 17:04
@bjarki-andreasen bjarki-andreasen marked this pull request as ready for review December 2, 2024 11:03
@bjarki-andreasen bjarki-andreasen force-pushed the nordic-global-hsfll branch 3 times, most recently from b747f86 to 20b7ee7 Compare December 2, 2024 12:56
@bjarki-andreasen bjarki-andreasen force-pushed the nordic-global-hsfll branch 2 times, most recently from 6a25a3f to 4b49be5 Compare December 4, 2024 10:45
@mstasiaknordic mstasiaknordic mentioned this pull request Dec 12, 2024
Merged
@bjarki-andreasen bjarki-andreasen force-pushed the nordic-global-hsfll branch 2 times, most recently from 93baa35 to b71c640 Compare December 12, 2024 11:36
@nordic-krch
Copy link
Contributor

Enabling those features with CONFIG_CLOCK_CONTROL=y leads to enabling of DVFS on cpuapp and by default DVFS will set up for the lowest operational point (64 MHz) on cpuapp. This may come as a surprise to the user as suddenly performance drops 5 times. In that case I wonder if we should not enable clock control by default.

@NordicBuilder NordicBuilder removed the DNM label Dec 12, 2024
@bjarki-andreasen bjarki-andreasen force-pushed the nordic-global-hsfll branch 3 times, most recently from bfc81c6 to 7baf9bb Compare December 12, 2024 14:52
krish2718 and others added 5 commits December 12, 2024 15:55
@krish2718 @bjarki-andreasen
[nrf fromtree] manifest: hal_nordic: Pull nRF Wi-Fi removal
74aec6e 
Pulls PR that removed nRF Wi-Fi.

(cherry picked from commit e512151)

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718 @bjarki-andreasen
[nrf fromtree] root: Remove temp file
d382adf 
Commit e512151("manifest: hal_nordic: Pull nRF Wi-Fi removal")
mistakenly added a temporary local file.

Signed-off-by: Chaitanya Tata <[email protected]>

(cherry picked from commit 7658adf)
@aescolar @bjarki-andreasen
[nrf fromtree] manifest: hal_nordic: Update to latest
3e36aa5 
Including not removing a workaround in the UART driver for bsim targets

(cherry picked from commit 6c7b38f)

Signed-off-by: Alberto Escolar Piedras <[email protected]>
@carlescufi @bjarki-andreasen
[nrf fromtree] manifest: Update the hal_nordic revision to get the la…
fb63a60 
…test suit blob

See zephyrproject-rtos/hal_nordic#267 for
additional details.

(cherry picked from commit 96f2b2f)

Signed-off-by: Carles Cufi <[email protected]>
@bjarki-andreasen
[nrf fromlist] manifest: hal_nordic: update to include nrfs services
2522ec4 
Update hal_nordic revision to include nrfs services:
- GDPWR
- GDFS

Upstream PR #: 81735

Signed-off-by: Bjarki Arge Andreasen <[email protected]>
@bjarki-andreasen
Copy link
Contributor Author

Enabling those features with CONFIG_CLOCK_CONTROL=y leads to enabling of DVFS on cpuapp and by default DVFS will set up for the lowest operational point (64 MHz) on cpuapp. This may come as a surprise to the user as suddenly performance drops 5 times. In that case I wonder if we should not enable clock control by default.

Clock control is not enabled by default :) If its enabled, then yes, application developer must request higher freq when needed, that's what its for :)

@gmarull @bjarki-andreasen
[nrf fromlist] soc: nordic: nrf54h: gpd: align GPD domain names
7ab138a 
nRFs exposes now all power domains, following their actual name in the
specification. Add support for all of them in the GPD service. Note that
this is a breaking change: running this code requires a new SCFW as IDs
have changed in nRFs and so SCFW.

Upstream PR #: 81735

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@bjarki-andreasen bjarki-andreasen force-pushed the nordic-global-hsfll branch 2 times, most recently from 29a458c to 5a81aa5 Compare December 12, 2024 15:19
ppelikan-nordic and others added 6 commits December 13, 2024 09:46
@ppelikan-nordic @bjarki-andreasen
[nrf fromlist] modules: hal_nordic: nrfs: add GDFS Service
a5edcf4 
Adding the implementation for the GDFS service

Upstream PR #: 81735

Signed-off-by: Paweł Pelikan <[email protected]>
@bjarki-andreasen
[nrf fromlist] dts: nordic: specify device model of global hsfll clock
cea0d9d 
Add specific device model for global hsfll clock and update dts tree
to use specific model. The clock is not fixed, and configurable at
runtime to predefined frequencies specified by the platform.

Upstream PR #: 81735

Signed-off-by: Bjarki Arge Andreasen <[email protected]>
@bjarki-andreasen
[nrf fromlist] dts: bindings: update nrf-hsfll to nrf-hsfll-local
0105b0d 
The nrf-hsfll was previously the only supported HSFLL clock, hence it
was not namespaced fully. Since we added nrf-hsfll-global, we should
add the namespace to nrf-hsfll as well.

Updates drivers and devicetree uses of HSFLL as well.

Upstream PR #: 81735

Signed-off-by: Bjarki Arge Andreasen <[email protected]>
@bjarki-andreasen
[nrf fromlist] drivers: clock_control: nrf2: add support for global h…
37d1280 
…fsll clock

Add device driver support for global hsfll clock.

Upstream PR #: 81735

Signed-off-by: Bjarki Arge Andreasen <[email protected]>
@bjarki-andreasen
[nrf fromlist] samples: boards: nordic: clock_control: support global…
c581652 
… hsfll

Extend sample to support global hsfll clock control.

Upstream PR #: 81735

Signed-off-by: Bjarki Arge Andreasen <[email protected]>
@bjarki-andreasen
[nrf fromlist] tests: drivers: clock_control: nrf: add global hsfll c…
8eea788 
…lock

Extend test suite to test global HSFLL clock.

Upstream PR #: 81735

Signed-off-by: Bjarki Arge Andreasen <[email protected]>
@bjarki-andreasen bjarki-andreasen merged commit 0f2b574 into nrfconnect:main Dec 13, 2024
16 checks passed
@krish2718 krish2718 mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmon-nordic tmon-nordic tmon-nordic left review comments

@ppryga-nordic ppryga-nordic ppryga-nordic left review comments

@lstnl lstnl lstnl approved these changes

@hakonfam hakonfam hakonfam approved these changes

@anangl anangl Awaiting requested review from anangl anangl is a code owner

@nordic-krch nordic-krch Awaiting requested review from nordic-krch nordic-krch is a code owner

@carlescufi carlescufi Awaiting requested review from carlescufi

@de-nordic de-nordic Awaiting requested review from de-nordic

@nordic-piks nordic-piks Awaiting requested review from nordic-piks

Assignees
No one assigned
Labels
manifest manifest-hal_nordic
Projects
None yet
Milestone
ncs-2.9.0-nRF54H20-1
Development

Successfully merging this pull request may close these issues.